kicad-developers team mailing list archive

[jp charras <jp.charras@xxxxxxxxxx>]

Le 19/12/2018 à 04:48, Seth Hillbrand a écrit :
> Am 2018-12-18 14:19, schrieb jp charras:
>>
>> Sorry Seth,
>>
>> But with your fixes, CacheTriangulation() crashes with degenerated
>> polygons.
>>
>> To see that, modify gerbview_painter.cpp, line 265 to remove
>> absolutePolygon.COutline( 0 ).PointCount() < 3
>> and try to load the test file test_polygons_with_arcs.gbr in Gerbview.
> 
> Hi JP-
> 
> Thanks for finding that.  The issue was that the Fracture() call
> resulted in an empty polygon set with no outlines and I hadn't re-tested
> its validity.  64f1fb9e7 fixes the bug.
> 
> -Seth


Looks good to me now.
And CacheTriangulation() is really faster than GLU tesselation.
Thanks.


-- 
Jean-Pierre CHARRAS