kicad-developers team mailing list archive
Mailing list archive
Re: Issue with wxWidgets 3.1.2 - MSW. Need GAL gurus help.
Maciej Suminski <maciej.suminski@xxxxxxx>
Wed, 26 Dec 2018 16:19:43 +0100
spf=pass (sender IP is 18.104.22.168) smtp.mailfrom=cern.ch; lists.launchpad.net; dkim=none (message not signed) header.d=none;lists.launchpad.net; dmarc=bestguesspass action=none header.from=cern.ch;
addr=maciej.suminski@xxxxxxx; prefer-encrypt=mutual; keydata= mQENBFKfmAwBCAC9tak+4mDO1WiNnAwegusPBMEdl+sV35XeaU4PGSt33mPSlXB2klamg4ih QUykvuWqNEg2KyTvCSKNfnHTpzeeFegEsIwWFdhbIc4uUAD6CHl4+uGTXQiMh1+IJkgLmwuD RCEx9mSKbdzzTKz05w+fzzT3mNfko8NICWlcmhFgo2RXnQRTqFg7CNNBpx4kr4+AWIvb+Rha AVMLVJj1s05+STGyFucu6sZmTmOC53ZtkV8HchJeGuQL0LPkjvX0VKGE3gkvuP4iLBcgFtNC Kcu/L6FmWd24m2IhWaHXoWLBiVFw7gGzUdB7gSAiNO1+SoWX+99rbud7RvqV49vOgoqbABEB AAG0KU1hY2llaiBTdW1pbnNraSA8bWFjaWVqLnN1bWluc2tpQGNlcm4uY2g+iQE5BBMBAgAj BQJSn5gMAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQFHAa7WGlsnU/JQf5AYW0 oFH+jOykZvlRkRZMoqw1vZGOHeRPK92vbjeiau/hALYX1FBvZMx+JMmVHN7DkRIY7bVoiJ6N n4Byn//BSd9F9eXjAphYVuBg2Xe5wp3/l9/z2Iw8KeLpfKAtfIybgpycvTuUxFIxm9mtpPt+ AoNFKBDhfLcpZLJTW7AwwpnzP+GDdjszjnW6rMt8Aq55liR+y/TZfz/tTEDcUcSPLlJBTmda TmkO5aPxPmeCeDMOT3YEd+bK57V5b7RgtqTdIT6CW7tjQKBPJbIGa8PQ0tUfz0yCBEPWghnY w+B/2JeArrRXDui78cGgTDy1ocQNAm3havk2WO2qykxziY6OwbkBDQRSn5gMAQgAxw+MRllT IPNnCeOAbRgX1KRzo7+7WpSIbmhrBzLY0O1SyIa7U05E6+4jDHDfDpSLqc61an1+M69e6l9Z E3ve3hymtj5ucXZQnveQ5klD6z5FBC/04of/YyrS+h6iRSM0nOmu1JOIqM0S2OzwsKRsS86r jCtRE5OxoBDCIB4xNPitezs4uvLoVfO3mVYUhiPRZMtTCInEi+tlM+AmaPjRkPAfhd0wsOjk oxkuJWEnZ8U8oHpeL0uqANZgLlIiT5yJMWsyyqlK01hdFbuIydIFFiyXJw1HDTXWX+tMxJrX VEvQJZALof9RU/jntqGltnQXArUgPMSGGu1f+7AH/CuMyQARAQABiQEfBBgBAgAJBQJSn5gM AhsMAAoJEBRwGu1hpbJ1maAH/RZPbvXaNIOouHZlnlkq/WORHxjkKfve+AbE62Ed8yFIwlAj tyZGKeEG9hDJl6f9BxDv+9qunTfWfXQuHxNIpdXstkxQIx4m043Kx3h7VdEmg53ybeGNgpvz BYk5HdgCH3yP6UbGNiel6xZOywmvpru3pEKNg4mJhzxm9JCG+djrvbRh+BZNOkDBgaSiCAuJ q6Ffo9Qk/qfl6Uim9G7GKSS4930ZQ2GoVObe+jXixOhWXFSDhGKX5meABmELJ9XTcW3Pp6XC 0KXOE2p0EHQPmFvXdU6OePI72jTgRzPJXRXbPkL0/NUfbZfxS/xnAG8jmODc2ufbtrvE2jPu INX35u4=
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0
On 12/22/18 8:04 PM, jp charras wrote:
> Le 22/12/2018 à 18:49, Maciej Suminski a écrit :
>> On 12/21/18 8:22 PM, jp charras wrote:
>>> I very recently updated wxWidgets from 3.1.1 to 3.1.2
>>> I ran into a problem with Pcbnew and Gerbview (Not eeschema, that has a
>>> different event handler):
>>> The context menus Zoom selection and Grid Selection are no longer
>>> working (and presumably any other context submenu).
>>> I had a look into this issue (MSW specific).
>>> The 3.1.1 and the 3.1.2 have different behaviors.
>>> The attached patch fixes this issue.
>>> However I do not understand this code in context_menu.cpp line 361:
>>> if( menu && menu != this )
>>> The condition " && menu != this" is the culprit:
>>> in wxWidgets 3.1.2, menu == this happens always.
>>> in wxWidgets 3.1.2, menu == this happens never.
>>> This line has no comment, and must be modified.
>>> I'll be happy if Thomasz or Orson could have a look into that issue, and
>>> that change and if this condition can be explained, if it is needed.
>> Hi Jean-Pierre,
>> The commit message for the mentioned line says "Fix for clarification
>> menu crash (GAL/Windows)". Unfortunately, it had been committed before
>> we started using 'Fixes:' tag, so I cannot point to a particular bug
>> report. My impression is that FindItem() could return the same menu
>> object, ultimately leading to an infinite loop on Windows.
>> I will try your patch later with an wxWidgets 3.0.x version to see if
>> removing the condition causes any problems.
> Hi Orson,
> Thanks to have a look into this problem.
> I just saw the "Set Language" menu has a similar issue (sub-menus do not
> work), but my fix does not work for this menu.
> However, because it also does not work in Eeschema, I am guessing it
> could be a different issue.
I have checked the proposed patch with wxMSW 3.0.4 and it works fine.
Moreover, even with without 'menu != this' condition, I have not
observed any issues. I think there might have been a problem with an
older version of wxWidgets, or it is now fixed somewhere else.
Description: OpenPGP digital signature