kicad-developers team mailing list archive

Thread
Date

Re: [PATCH] Pcbnew unit test framework

To: John Beard <john.j.beard@xxxxxxxxx>
From: Seth Hillbrand <seth@xxxxxxxxxxxxx>
Date: Sun, 06 Jan 2019 11:15:22 -0500
Cc: Kicad Developers <kicad-developers@xxxxxxxxxxxxxxxxxxx>
In-reply-to: <CAG1r56LN7tq2YY6FShhKKw9foO70VZ9YZL=6xmonGcjd2t-V9A@mail.gmail.com>
User-agent: Roundcube Webmail/1.3.6

Am 2019-01-05 19:24, schrieb John Beard:

On Sat, Jan 5, 2019 at 4:23 PM Seth Hillbrand <seth@xxxxxxxxxxxxx>wrote:

Patch 0002 does not apply cleanly to qa/CMakeLists.txt even after
applying 0001


Hmm, that's odd: I can apply this with "git am 0002....". I'm applying
on top of 69fc301bf. Where are you applying it to? Do you still have
the triangulation test code in your tree? IIRC there is a conflict in
that file.

Very odd. I ended up doing a 3way merge and hand-editing the result.Please check that I didn't mix anything up. The conflict was (I think)an extra line in qa/CMakeLists.txt.


The tests and patch seems to work as expected.  Thanks!

-S

Follow ups

Re: [PATCH] Pcbnew unit test framework
From: Nick Østergaard, 2019-01-06

References

[PATCH] Pcbnew unit test framework
From: John Beard, 2019-01-04
Re: [PATCH] Pcbnew unit test framework
From: Seth Hillbrand, 2019-01-05
Re: [PATCH] Pcbnew unit test framework
From: John Beard, 2019-01-06