kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Hey John,

I only see three tests.  Does your latest patch enable this so I can
test it?

Cheers,

Wayne

On 1/7/2019 8:39 AM, John Beard wrote:
> Hi Wayne,
> 
> 3f9230fa5 doesn't have add_subdirectory( pcbnew ) in
> qa/CMakeLists.txt, because the reversion of the merge conflicts with
> the stray patch removed it.
> 
> if you add the add_subdirectory( pcbnew ) line back, it is reported to
> break on some systems. This could be a CMake version thing, but all
> the systems I have tried work, so it's kind of hard for me to tell.
> 
> You can tell if you have the pcbnew unit tests are working if "make
> test" runs 4 tests, not 3 (or if the executable qa/pcbnew/qa_pcbnew is
> built).
> 
> Cheers,
> 
> John
> 
> On Mon, Jan 7, 2019 at 1:06 PM Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>>
>> I just ran a 32 bit build on windows with commit 3f9230fa and I didn't
>> have any build or test issues.
>>
>> Cheers,
>>
>> Wayne
>>
>> On 1/7/2019 8:00 AM, John Beard wrote:
>>> Hi JP,
>>>
>>> Sorry, I thought that issue was just a side effect of conflicted
>>> merges in these files, but maybe not. I had built this code on Linux
>>> GCC, Windows Msys2 and MSVC on Simon's Jenkins with no issues, so I'm
>>> working blind in trying to fix it.
>>>
>>> I think it might be an issue with older CMakes, but I cannot test this
>>> as I do not know of a CI target I could use to check. I am rebuilding
>>> on Jenkins now, but since it takes an hour and doesn't even show the
>>> error, I'd like to know if I have also fixed it for you.
>>>
>>> Here's an attempt to fix it (replaces prior patch).
>>>
>>> What is the right way for me to check these patches are correct in
>>> future? It is frustrating to submit patches that break builds that I
>>> have no way to predict or detect, and I'm sure it frustrating for
>>> maintainers to waste so much time speculatively building patches and
>>> replying to emails with the failures.
>>>
>>> Cheers,
>>>
>>> John
>>>
>>> On Mon, Jan 7, 2019 at 11:42 AM jp charras <jp.charras@xxxxxxxxxx> wrote:
>>>>
>>>> Le 07/01/2019 à 12:33, John Beard a écrit :
>>>>> Hi Seth,
>>>>>
>>>>> The revert commit (8f11a2133efd95526d1a3783dbaca76f732b8efb) also
>>>>> killed the CMake add_subdirectory (because the original commit was
>>>>> conflicted). Here is a patch to put it back in order (and put the
>>>>> existing subdirs into some order).
>>>>>
>>>>> Cheers,
>>>>>
>>>>> John
>>>>>
>>>>
>>>> Hi John,
>>>>
>>>> As previously reported, the add_subdirectory pcbnew breaks the windows
>>>> build and some Linux builds.
>>>>
>>>> Please, first fix the the build issue in qa/pcbnew.
>>>>
>>>> Thanks.
>>>>
>>>>
>>>> --
>>>> Jean-Pierre CHARRAS
>>>>
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>> More help   : https://help.launchpad.net/ListHelp
>>>>
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>> More help   : https://help.launchpad.net/ListHelp
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp