kicad-developers team mailing list archive
Mailing list archive
Re: [PATCH] Wildcard tests + removed variadic interface
Am 2019-01-08 09:16, schrieb John Beard:
Here are some patches for wildcards:
* Add some tests to demo the API and expected output.
* Remove a variadic function signature and replace with one that takes
a std::vector<std::string>. This allows better and more typesafe use
of this API at run time.
* Unify the "all files" wildcard handling. Avoids unexpected needs to
call translation functions and sticks to a single idiom for getting
wildcards (call one of these functions).
Could a Windows user please check `make test` works before commit? I
did check it by fiddling with the defines, but good to be sure.
wx provides wxFileSelectorDefaultWildcardStr that maps to the
appropriate "*.*" for Windows and "*" for Mac/Linux. You may want to
utilize that instead of the hard-coded "*"