kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #38909
Re: [PATCH] Wildcard tests + removed variadic interface
-
To:
kicad-developers@xxxxxxxxxxxxxxxxxxx
-
From:
jp charras <jp.charras@xxxxxxxxxx>
-
Date:
Tue, 8 Jan 2019 19:54:43 +0100
-
In-reply-to:
<CAG1r56L1HLytaxqQBSPUwk74fVqNtKfmURTY=r5XR2PV_LWVhg@mail.gmail.com>
-
Openpgp:
preference=signencrypt
-
User-agent:
Mozilla/5.0 (Windows NT 6.1; rv:60.0) Gecko/20100101 Thunderbird/60.4.0
Le 08/01/2019 à 18:35, John Beard a écrit :
> Hi Seth,
>
> Here are updated patches (only #3 is changed).
>
> I have still hardcoded the expected results in the test, otherwise
> it'll be a fairly opaque test of two copy-pasted lines.
>
> The windows filter is now " (*.*)|*.*": is that right?
>
> Cheers,
>
> John
>
> On Tue, Jan 8, 2019 at 4:48 PM Seth Hillbrand <seth@xxxxxxxxxxxxx> wrote:
>>
>> Am 2019-01-08 11:46, schrieb John Beard:
>>> Hi Seth,
>>>
>>> Good idea - I was just moving what the code currently did, but sounds
>>> like a sensible fix. I'll amend patch 0003.
>>>
>>> Does it otherwise work on Windows?
Hi John,
I just made a fast test on W7using your latest patches.
I did not notice any issue, and the command:
make test
runs qa tests without problem.
--
Jean-Pierre CHARRAS
References