← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Wildcard tests + removed variadic interface

 

Le 08/01/2019 à 18:35, John Beard a écrit :
> Hi Seth,
> 
> Here are updated patches (only #3 is changed).
> 
> I have still hardcoded the expected results in the test, otherwise
> it'll be a fairly opaque test of two copy-pasted lines.
> 
> The windows filter is now " (*.*)|*.*": is that right?
> 
> Cheers,
> 
> John
> 
> On Tue, Jan 8, 2019 at 4:48 PM Seth Hillbrand <seth@xxxxxxxxxxxxx> wrote:
>>
>> Am 2019-01-08 11:46, schrieb John Beard:
>>> Hi Seth,
>>>
>>> Good idea - I was just moving what the code currently did, but sounds
>>> like a sensible fix. I'll amend patch 0003.
>>>
>>> Does it otherwise work on Windows?

Hi John,

I just made a fast test on W7using your latest patches.
I did not notice any issue, and the command:
make test
runs qa tests without problem.

-- 
Jean-Pierre CHARRAS


References