kicad-developers team mailing list archive
Mailing list archive
Re: [PATCH] Wildcard tests + removed variadic interface
Wayne Stambaugh <stambaughw@xxxxxxxxx>
Tue, 8 Jan 2019 20:57:41 -0500
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0
Would you please rebase your patches? Patch 0001 no longer applies
cleaning. Apparently someone made a change the caused a conflict before
I could get around to merging them.
On 1/8/2019 12:35 PM, John Beard wrote:
> Hi Seth,
> Here are updated patches (only #3 is changed).
> I have still hardcoded the expected results in the test, otherwise
> it'll be a fairly opaque test of two copy-pasted lines.
> The windows filter is now " (*.*)|*.*": is that right?
> On Tue, Jan 8, 2019 at 4:48 PM Seth Hillbrand <seth@xxxxxxxxxxxxx> wrote:
>> Am 2019-01-08 11:46, schrieb John Beard:
>>> Hi Seth,
>>> Good idea - I was just moving what the code currently did, but sounds
>>> like a sensible fix. I'll amend patch 0003.
>>> Does it otherwise work on Windows?
>> Unfortunately, I don't have a Windows setup so we'll need to wait for an
>> available Windows tester on the patch.
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help : https://help.launchpad.net/ListHelp