kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #38923
Re: [PATCH] Wrong windows macro
-
To:
kicad-developers@xxxxxxxxxxxxxxxxxxx
-
From:
Wayne Stambaugh <stambaughw@xxxxxxxxx>
-
Date:
Wed, 9 Jan 2019 09:18:20 -0500
-
In-reply-to:
<CAG1r56LwJJ=E3xZfH0cK-rGTxnZkT3F=c1WxyZsH9v42r+tA9Q@mail.gmail.com>
-
User-agent:
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0
John,
Patch merged. Nice catch!
Thanks,
Wayne
On 1/8/2019 12:56 PM, John Beard wrote:
> Hi,
>
> Quick patch for a misuse of __WXWINDOWS__ for checking the presence of
> Windows. The correct macro is __WINDOWS__ or __WXMSW__ in GUI
> programs.
>
> __WXWINDOWS__ is always set, on all platforms.
>
> The alternative is to remove the ifdef entirely, as this is not a big
> issue to do on non-windows platforms, as it has been doing this
> quietly since Feb 2018!
>
> Cheers,
>
> John
>
> Ref: https://docs.wxwidgets.org/3.0/page_cppconst.html
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
References