kicad-developers team mailing list archive

[mdoesbur@xxxxxxxxx]

Hello Wayne,

Please consider it on hold for now. Once kicad supports netclass to
netclass clearances I will have another look. The dimensions are not
copied yet, since I stopped working on it once I found out that all
the unnamed nets lost their netclass after the first update from the
schematic. This may be easy to fix or not, but at that point I decided
to simply forget it.

regards,

Mark

Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:

	Hey Mark,

	On 1/11/2019 5:11 AM, mdoesbur@xxxxxxxxx wrote:
	> Here's a patch to import the netclasses from eagle.

	There are a few minor coding policy issues.  We now have clang
	formatting available when you perform a git commit if you would prefer
	not to have to remember KiCad's formatting.  You just have to enable it
	in your git repo if that is your preference.

	It looks like there is some left over debugging code (using std::cerr)
	that needs to be removed.  If you want leave debugging support in your
	code, please use wxLogTrace[1].

	I looks like you are translating Eagle units directly to kicad's pcb
	units.  Is this valid?  I don't know what internal units Eagle uses for
	boards but KiCad uses 1nm.  If Eagle doesn't use 1nm, then your unit
	conversions are wrong.

	> 
	> As already mentioned, all nets without a label are in the default
	> netclass. The clearances are ignored because I have no idea what clearance
	> to use. The trackwidths are ignored, I've never used that and saw no
	> reason to fix this since the patch isn't that usefull anyway.

	Does Eagle specify a default net clearance?  If so, we should be using
	that instead of the KiCad default net clearance for the nets not
	assigned to a netclass.

	Would our resident Eagle file format expert please take a look at this
	patch to see if it makes sense?  I'm not terribly familiar with the
	Eagle file format.

	Cheers,

	Wayne

	[1]:
	https://docs.wxwidgets.org/3.0/group__group__funcmacro__log.html#gae28a46b220921cd87a6f75f0842294c5

	> 
	> regards,
	> 
	> Mark.
	> 
	> Seth Hillbrand <seth@xxxxxxxxxxxxx> wrote:
	> 
	> 	<div dir='auto'>Hi Mark-<div dir="auto"><br></div><div dir="auto">That would be great, thanks!</div><div dir="auto"><br></div><div dir="auto">-Seth</div></div>
	> 
	> 
	> _______________________________________________
	> Mailing list: https://launchpad.net/~kicad-developers
	> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
	> Unsubscribe : https://launchpad.net/~kicad-developers
	> More help   : https://help.launchpad.net/ListHelp
	> 

	_______________________________________________
	Mailing list: https://launchpad.net/~kicad-developers
	Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
	Unsubscribe : https://launchpad.net/~kicad-developers
	More help   : https://help.launchpad.net/ListHelp