kicad-developers team mailing list archive

["Steven A. Falco" <stevenfalco@xxxxxxxxx>]

A recent commit, "pcbnew: Prevent GITHUB plugin from being registered", seems to have caused my copr build to fail.

Fedora has "BUILD_GITHUB_PLUGIN=ON".  I get this error:

[ 18%] Building CXX object common/CMakeFiles/pcbcommon.dir/__/pcbnew/io_mgr.cpp.o
cd /builddir/build/BUILD/kicad-r14777-54334233/common && /usr/bin/c++  -DGLM_FORCE_CTOR_INIT -DHAVE_STDINT_H -DKICAD_SCRIPTING -DKICAD_SCRIPTING_ACTION_MENU -DKICAD_SCRIPTING_MODULES -DKICAD_SPICE -DKICAD_USE_OCE -DWXUSINGDLL -DWX_COMPATIBILITY -D_FILE_OFFSET_BITS=64 -D__WXGTK__ -DPCBNEW -I/builddir/build/BUILD/kicad-r14777-54334233/include -I/builddir/build/BUILD/kicad-r14777-54334233/common/. -I/builddir/build/BUILD/kicad-r14777-54334233/common/./dialogs -I/builddir/build/BUILD/kicad-r14777-54334233/common/./widgets -I/builddir/build/BUILD/kicad-r14777-54334233/common/./dialog_about -I/usr/include/cairo -I/usr/include/pixman-1 -I/builddir/build/BUILD/kicad-r14777-54334233/common/../3d-viewer -I/builddir/build/BUILD/kicad-r14777-54334233/common/../pcbnew -I/builddir/build/BUILD/kicad-r14777-54334233/common/../polygon -I/builddir/build/BUILD/kicad-r14777-54334233 -I/usr/include/python2.7 -I/builddir/build/BUILD/kicad-r14777-54334233/scripting -I/usr/lib64/oce-0.18/../../include/oce -I/builddir/build/BUILD/kicad-r14777-54334233/common/../include/legacy_wx -isystem /usr/lib64/wx/include/gtk2-unicode-3.0 -isystem /usr/include/wx-3.0  -Wall -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -Wsuggest-override -Werror=vla -Wno-unused-local-typedefs -Wno-strict-aliasing -pthread -Wshadow -g3 -ggdb3 -DDEBUG -Wno-deprecated-declarations -fPIC -fvisibility=hidden -fvisibility-inlines-hidden   -std=gnu++11 -o CMakeFiles/pcbcommon.dir/__/pcbnew/io_mgr.cpp.o -c /builddir/build/BUILD/kicad-r14777-54334233/pcbnew/io_mgr.cpp
BUILDSTDERR: /builddir/build/BUILD/kicad-r14777-54334233/pcbnew/io_mgr.cpp: In static member function 'static IO_MGR::PCB_FILE_T IO_MGR::GuessPluginTypeFromLibPath(const wxString&)':
BUILDSTDERR: /builddir/build/BUILD/kicad-r14777-54334233/pcbnew/io_mgr.cpp:164:19: error: 'GITHUB' was not declared in this scope
BUILDSTDERR:              ret = GITHUB;
BUILDSTDERR:                    ^~~~~~
BUILDSTDERR: /builddir/build/BUILD/kicad-r14777-54334233/pcbnew/io_mgr.cpp:164:19: note: suggested alternative: 'SIGHUP'
BUILDSTDERR:              ret = GITHUB;
BUILDSTDERR:                    ^~~~~~
BUILDSTDERR:                    SIGHUP
BUILDSTDERR: /builddir/build/BUILD/kicad-r14777-54334233/pcbnew/io_mgr.cpp: At global scope:
BUILDSTDERR: /builddir/build/BUILD/kicad-r14777-54334233/pcbnew/io_mgr.cpp:208:62: error: 'GITHUB' is not a member of 'IO_MGR'
BUILDSTDERR:  static IO_MGR::REGISTER_PLUGIN registerGithubPlugin( IO_MGR::GITHUB, wxT("Github"), []() -> PLUGIN* { return new GITHUB_PLUGIN; } );
BUILDSTDERR:                                                               ^~~~~~
BUILDSTDERR: make[2]: *** [common/CMakeFiles/pcbcommon.dir/build.make:556: common/CMakeFiles/pcbcommon.dir/__/pcbnew/io_mgr.cpp.o] Error 1

At first I thought the compile bug was caused by a corrupt repo, because the nightlies were building correctly.  However, I now see that this change was just committed today, so the nightlies have not yet been affected.

I'm running a test build with the GitHub plugin turned off, and it got past the above file without error.

How is this supposed to work?  Should we just disable the plugin?  Or if we want to keep it, is there something new that we have to do to get it to build?

	Steve