← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Add "noexcept" to a few functions (2)

 

Am 2019-01-23 17:28, schrieb Simon Richter:
Automated code analysis says that these cannot throw exceptions and can be
marked "noexcept".
---
 3d-viewer/3d_canvas/cinfo3d_visu.h                 | 13 +++++----
 3d-viewer/3d_canvas/eda_3d_canvas.h                |  9 ++++--
 3d-viewer/3d_canvas/status_text_reporter.h         |  4 +--
 3d-viewer/3d_fastmath.cpp                          |  6 ++--
 3d-viewer/3d_fastmath.h                            | 14 +++++-----
 3d-viewer/3d_math.h                                |  6 ++--
 3d-viewer/3d_model_viewer/c3d_model_viewer.cpp     |  2 +-
 3d-viewer/3d_model_viewer/c3d_model_viewer.h       |  2 +-
 .../3d_render_ogl_legacy/c3d_render_ogl_legacy.cpp |  8 +++---
 .../3d_render_ogl_legacy/c3d_render_ogl_legacy.h   | 12 ++++----
 .../3d_render_ogl_legacy/c_ogl_3dmodel.cpp         |  8 +++---
 .../3d_render_ogl_legacy/c_ogl_3dmodel.h           | 10 +++----
 .../3d_render_ogl_legacy/clayer_triangles.cpp      |  8 +++---
 .../3d_render_ogl_legacy/clayer_triangles.h        | 18 ++++++------
 .../3d_render_raytracing/PerlinNoise.cpp           |  8 +++---
 .../3d_render_raytracing/PerlinNoise.h             |  8 +++---
 .../accelerators/cbvh_pbrt.cpp                     | 10 +++----
 .../3d_render_raytracing/accelerators/ccontainer.h |  4 +--
 .../accelerators/ccontainer2d.cpp                  |  2 +-
 .../accelerators/ccontainer2d.h                    |  4 +--
 .../3d_render_raytracing/c3d_render_raytracing.cpp |  8 +++---
 .../3d_render_raytracing/c3d_render_raytracing.h   |  6 ++--
 .../3d_rendering/3d_render_raytracing/clight.h     |  8 +++---
.../3d_rendering/3d_render_raytracing/cmaterial.h | 32 +++++++++++-----------
 .../3d_render_raytracing/mortoncodes.cpp           |  8 +++---
 .../3d_rendering/3d_render_raytracing/ray.cpp      |  2 +-
 3d-viewer/3d_rendering/3d_render_raytracing/ray.h  |  2 +-
 .../3d_render_raytracing/shapes2D/cbbox2d.cpp      |  8 +++---
 .../3d_render_raytracing/shapes2D/cbbox2d.h        | 12 ++++----
 .../shapes2D/cfilledcircle2d.cpp                   |  2 +-
 .../shapes2D/cfilledcircle2d.h                     |  8 +++---
 .../shapes2D/citemlayercsg2d.cpp                   |  4 +--
 .../shapes2D/citemlayercsg2d.h                     |  4 +--
 .../3d_render_raytracing/shapes2D/cobject2d.cpp    |  2 +-
 .../3d_render_raytracing/shapes2D/cobject2d.h      |  4 +--
 35 files changed, 136 insertions(+), 130 deletions(-)


Hi Simon-

I think that these make sense. However, I've been bitten by automated suggestions in the past and would feel more comfortable if we apply these after v5.1 is out. Can you resend these patches once the v6 development is open?

-Seth


Follow ups

References