kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Hey John,

Fair enough but I cannot see how the polygon changes could have broken
the common_eeschema tests.  I merged your patch set.  Hopefully test
failures will get resolved in the not too distant future.

Cheers,

Wayne

On 1/29/2019 9:28 AM, John Beard wrote:
> Hi Wayne,
> 
> Yes, it's the same failure, just moved into qa_common. Just a sad
> quirk of timing that this thing was exposed at this particular moment
> after being untouched for ages!
> 
> Selfishly, I'd rather these patches were merged first, then the
> polygon issue fixed, or I'll need to rebase the series and fix the
> conflicts. Whereas merging first, then fixing, would not require a
> conflict resolution. I'm willing to fix it as a follow up to this
> patch series, but I am still unsure of whether a point on a "hole
> edge" of the polygon counts as in or outside. If it's outside, the
> POLY_SET implementation is still wrong.
> 
> Cheers,
> 
> John
> 
> On Tue, Jan 29, 2019 at 1:30 PM Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>>
>> John,
>>
>> I'm getting test failures with common_gerbview, common_eeschema, and
>> common_pcbnew.  I'm guessing the common_pcbnew is due to the recent
>> polygon changes which broke the previous polygon test.  Does it make
>> sense to merge this unit the test failures are resolved?
>>
>> Cheers,
>>
>> Wayne
>>
>> On 1/25/2019 10:48 AM, John Beard wrote:
>>> Hi,
>>>
>>> Here are a few more patches to finish up consolidating most of the
>>> rest of the QA tools.
>>>
>>> 1) Adds some very basic dev-docs about the utility programs
>>> 2) Housekeeping in qa_utils (hide some code in KI_TEST)
>>> 3) qa_shape_factor_refactor is now only SHAPE_POLY_SET tests (the
>>> CPolyline stuff is gone), so move to qa_common where pure geom tests
>>> belong. Kill off this test executable.
>>> 4) Reinstate the polygon triangulation util under qa_pcbnew_tools
>>> 5) qa_pcbnew_tools: reuse common board reading code (useful when
>>> quickly prototyping with utilities)
>>>
>>> The only outstanding broken PCB-related QA things now should be:
>>>
>>> * pcb_test_window: what is this for and can it be fixed? Can it be
>>> made into a sub-tool, or does it need its own executable for the
>>> wxApp?
>>>
>>> Cheers,
>>>
>>> John
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp