← Back to team overview

kicad-developers team mailing list archive

Re: A trivial bug in a displayed string

 

Hi,

Here's a little patch. New text:  "Pin connected to other pins, but
not driven by any pin".

Cheers,

John

On Tue, Jan 29, 2019 at 6:33 PM Kevin Cozens <kevin@xxxxxxxxx> wrote:
>
> Greetings.
>
> For both the v5 and git master versions of Kicad in the file
> drc_erc_item.cpp on line 46 there is the string:
>     Pin connected to some others pins but no pin to drive it
>
> There should be no s on "others". The string might be better as:
>     Pin connected to other pins but no pin to drive it
>
> --
> Cheers!
>
> Kevin.
>
> http://www.ve3syb.ca/               | "Nerds make the shiny things that
> https://www.patreon.com/KevinCozens | distract the mouth-breathers, and
>                                      | that's why we're powerful"
> Owner of Elecraft K2 #2172          |
> #include <disclaimer/favourite>     |             --Chris Hardwick
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
From cca441b6477844d8fbc71f211b4d2fb2be310a90 Mon Sep 17 00:00:00 2001
From: John Beard <john.j.beard@xxxxxxxxx>
Date: Tue, 29 Jan 2019 21:49:44 +0000
Subject: [PATCH] Eeschema: fix grammar for text for ERCE_PIN_NOT_DRIVEN

Reported by Kevin Cozens on the mailing list.
---
 eeschema/drc_erc_item.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/eeschema/drc_erc_item.cpp b/eeschema/drc_erc_item.cpp
index 1bd8a470e..f9460a7c8 100644
--- a/eeschema/drc_erc_item.cpp
+++ b/eeschema/drc_erc_item.cpp
@@ -43,7 +43,7 @@ wxString DRC_ITEM::GetErrorText() const
     case ERCE_PIN_NOT_CONNECTED:
         return wxString( _("Pin not connected (use a \"no connection\" flag to suppress this error)") );
     case ERCE_PIN_NOT_DRIVEN:
-        return wxString( _("Pin connected to some others pins but no pin to drive it") );
+        return wxString( _( "Pin connected to other pins, but not driven by any pin" ) );
     case ERCE_PIN_TO_PIN_WARNING:
         return wxString( _("Conflict problem between pins. Severity: warning") );
     case ERCE_PIN_TO_PIN_ERROR:
-- 
2.20.1


Follow ups

References