← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] QA: Polyset Distance tests

 

Le 30/01/2019 à 10:47, John Beard a écrit :
> HI Wayne,
> 
> Thanks. I have realised there is a test failure in qa_common_eeschema
> caused by unit rounding. It's currently "masked" by the polyset
> failures.
> 
> Patches attached:
> 
> 1) Make polyset failures expected, so at least they won't mask other
> errors or kill CI jobs while the polysets are worked on (tests log the
> fail, but return 0)
> 2) Account for unit rounding in the Distance tests
> 3) A little unrelated tweak to a SHAPE_LINE_CHAIN ctor.
> 
> After these patches, I see a passing test suite again.
> 
> Cheers,
> 
> John

Hi John,

I tested your patches, and I have this error when building QA (W7
32bits, msys2):

CMakeFiles/qa_common_gerbview.dir/objects.a(test_shape_poly_set_distance.cpp.obj):
In function `ZNK5boost9function0IvE10get_vtableEv':
E:/kicad-launchpad/testing_git/qa/unit_test_utils/include/unit_test_utils/geometry.h:18:
multiple definition of `operator<<(std::ostream&, BOX2<VECTOR2<int> >
const&)'
CMakeFiles/qa_common_gerbview.dir/objects.a(test_shape_arc.cpp.obj):E:/kicad-launchpad/testing_git/qa/unit_test_utils/include/unit_test_utils/geometry.h:18:
first defined here
collect2.exe: error: ld returned 1 exit status
qa/common/CMakeFiles/qa_common_gerbview.dir/build.make:633: recipe for
target 'qa/common/qa_common_gerbview.exe' failed
make[2]: *** [qa/common/qa_common_gerbview.exe] Error 1
CMakeFiles/Makefile2:3218: recipe for target
'qa/common/CMakeFiles/qa_common_gerbview.dir/all' failed
make[1]: *** [qa/common/CMakeFiles/qa_common_gerbview.dir/all] Error 2


-- 
Jean-Pierre CHARRAS


Follow ups

References