← Back to team overview

kicad-developers team mailing list archive

Re: [patch] GAL pixel alignment

 

Le 11/02/2019 à 01:48, Wayne Stambaugh a écrit :
> Tom,
> 
> It looks really good.  I'm tempted to merge this but it's a fairly large
> change.  I think we should merge it after 5.1 is released and
> cherry-pick it for 5.1.1 unless we can get a lot of testing in the next
> week or two to ensure that it's stable across all platforms.
> 
> Cheers,
> 
> Wayne

Hi Wayne,

What about merging it in a 5.1-RC2 version.

The risk is low (of course not 0) and the benefit is high.
This is the only one way to have a lot of testing.

> 
> On 2/10/19 5:26 PM, Tomasz Wlostowski wrote:
>> Hi,
>>
>> The 3 attached patches add pixel alignment while drawing strokes in GAL
>> (both Cairo and OpenGL), resulting in sharp and uniform width lines
>> regardless of the zoom level and antialiasing settings. Current GAL
>> canvas does not round geometry to integer pixel coordinates, resulting
>> in sometimes blurred or jagged lines. I encourage you to test them,
>> especially at the OpenGL version (as it relies on the Vertex Shader for
>> the rounding/alignment).
>>
>> @Wayne do you think these can make to 5.1 (I guess it's too late) or
>> should we postpone them to V6?
>>
>> Cheers,
>> Tom
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


-- 
Jean-Pierre CHARRAS


Follow ups

References