kicad-developers team mailing list archive

[John Beard <john.j.beard@xxxxxxxxx>]

Hi Tom,

Thanks for looking at this - it's one of the last visible issues in
the new Eeschema GAL stuff that I notice regularly.

This appears to work well on Arch/i3.

I'd be in favour of at least attempting to get it into 5.1, as I think
the current eeschema look is likely to cause at least some moaning
upon general release (though I personally would be prepared to live
with it for the rest of 5.1, it's a long slog to v6).

*Tiny* nit-pick: junction circles seem to sometimes round down and
left, so when zoomed-out they are noticeably offset from the wire
junction. But this is not any kind of blocking issue IMO.

I'm not sure text is dramatically improved here: it's certainly less
fuzzy, but it's more distorted (eg. AN0 looks a bit like AND). But I
don't really mind either.

Cheers,

John

On Mon, Feb 11, 2019 at 10:14 AM jp charras <jp.charras@xxxxxxxxxx> wrote:
>
> Le 11/02/2019 à 01:48, Wayne Stambaugh a écrit :
> > Tom,
> >
> > It looks really good.  I'm tempted to merge this but it's a fairly large
> > change.  I think we should merge it after 5.1 is released and
> > cherry-pick it for 5.1.1 unless we can get a lot of testing in the next
> > week or two to ensure that it's stable across all platforms.
> >
> > Cheers,
> >
> > Wayne
>
> Hi Wayne,
>
> What about merging it in a 5.1-RC2 version.
>
> The risk is low (of course not 0) and the benefit is high.
> This is the only one way to have a lot of testing.
>
> >
> > On 2/10/19 5:26 PM, Tomasz Wlostowski wrote:
> >> Hi,
> >>
> >> The 3 attached patches add pixel alignment while drawing strokes in GAL
> >> (both Cairo and OpenGL), resulting in sharp and uniform width lines
> >> regardless of the zoom level and antialiasing settings. Current GAL
> >> canvas does not round geometry to integer pixel coordinates, resulting
> >> in sometimes blurred or jagged lines. I encourage you to test them,
> >> especially at the OpenGL version (as it relies on the Vertex Shader for
> >> the rounding/alignment).
> >>
> >> @Wayne do you think these can make to 5.1 (I guess it's too late) or
> >> should we postpone them to V6?
> >>
> >> Cheers,
> >> Tom
> >>
> >>
> >> _______________________________________________
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
> >>
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
>
> --
> Jean-Pierre CHARRAS
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

Attachment: New rendering (AA).png
Description: PNG image

Attachment: Old rendering (AA).png
Description: PNG image