← Back to team overview

kicad-developers team mailing list archive

Re: 3D viewer only using lower-left quadrant?

 

I just pushed this.  If someone could make sure that it doesn’t break other platforms that would be great.

Cheers,
Jeff.

> On 19 Feb 2019, at 16:17, Jeff Young <jeff@xxxxxxxxx> wrote:
> 
> Nice call, Bernhard.
> 
> That was indeed the issue.
> 
> Cheers,
> Jeff.
> 
> 
>> On 17 Feb 2019, at 16:09, Bernhard Stegmaier <stegmaier@xxxxxxxxxxxxx <mailto:stegmaier@xxxxxxxxxxxxx>> wrote:
>> 
>> Yes, it looks like that if you request to use full resolution but don’t get the backing scale stuff right (usually is 2, so you end up drawing only a quarter).
>> 
>> I’d guess that the rename of GetClientSize() to GetNativePixelSize() in HIDPI_GL_CANVAS wrapper is the bad guy… I don’t remember exactly, but I think this was an overload of some wx method to hide the backing scale stuff in Retina case from normal code.
>> 
>> 
>> Regards,
>> Bernhard
>> 
>>> On 17. Feb 2019, at 23:19, Nick Østergaard <oe.nick@xxxxxxxxx <mailto:oe.nick@xxxxxxxxx>> wrote:
>>> 
>>> I think we also saw this a long time ago with hidpibdisplays. Maybe the recent changes have undone something...
>>> 
>>> søn. 17. feb. 2019 23.17 skrev Tomasz Wlostowski <tomasz.wlostowski@xxxxxxx <mailto:tomasz.wlostowski@xxxxxxx>>:
>>> On 17/02/2019 23:04, Wayne Stambaugh wrote:
>>> > Looks fine on Linux.
>>> > 
>>> > On 2/17/19 4:50 PM, Jeff Young wrote:
>>> >> The 3D viewer on my machine is only using the lower-left quadrant.
>>> >>   Anyone else seeing this?
>>> 
>>> I noticed it a retina macbook too. Maybe a Retina-specific issue?
>>> 
>>> Tom
>>> 
>>> >>
>>> >>
>>> >> _______________________________________________
>>> >> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>> >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>> >> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>> >> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
>>> >>
>>> > 
>>> > _______________________________________________
>>> > Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>> > Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>> > More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
>>> 
>>> 
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
>> 
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


Follow ups

References