← Back to team overview

kicad-developers team mailing list archive

Re: V6 merge priority


Hi Wayne and the rest of the team,

My code is located here:
(I can rebase/format this as a patchset to make review easier if needed)

Documentation updates are in this branch:

Unfortunately, I've been very busy in the past few months and have not had
time to perform regular testing of my branch beyond checking that it
compiles as I merge upstream changes into it.
Since the branch has been feature complete for some time now, I would not
be terribly surprised if a bug or two has crept in due to the rest of the
code moving forward.

Please be aware that this branch contains an entirely new netlist generator
in order to support the new features.
This is exciting for the speed and feature improvements it makes possible,
but scary because of the consequences of getting anything wrong!
I have put in place a quality control check
(see NETLIST_EXPORTER_KICAD::WriteNetlist) that attempts to catch any
corner cases that I have not found already where the new algorithm is
inconsistent from the old, but there is always room for error here.
My thoughts were to keep in this code in master for some period of time
after merge, and then disable it or put it behind some flag after we have
more confidence in the new algorithm.  I welcome other suggestions here.
I would like it to get more visibility and testing so that any defects can
be corrected before merge, so that people who run nightly builds don't
suffer unnecessarily.
The new netlist exporter has also only been implemented for the KiCad
netlist format (not OrCad / CadStar / PSpice) as I wanted to get
review/approval of the new system before converting over the other

It's also worth noting that one of the new features does introduce a
schematic file format addition (bus aliases).
It would be possible to rip out this portion of the changes and stage it
for later merge if that were desirable.


On Sat, Mar 9, 2019 at 2:42 PM jp charras <jp.charras@xxxxxxxxxx> wrote:

> Le 09/03/2019 à 19:03, Wayne Stambaugh a écrit :
> > Rather than try to figure out every possible merge combination, I'm
> > going to prioritize things serially per editor.  The highest priority
> > are changes those that will or potentially impact later features.
> >
> > Jon's netlist work would be the obvious candidate for the schematic
> > editor.  Jon, please post the url of your git repo so we can review the
> > your changes.
> >
> > JP, don't you have some new pad work queued up?  I would think this
> > would impact things like Tom's router improvements.  If so, then this
> > should be the first board editor change that gets merged.  I would like
> > to take a look at the changes before we merge this.
> >
> > Once things stabilize, I will open up the next two feature merges.
> > Everyone please take the time to review these merges when you get a
> chance.
> >
> > Thanks
> >
> > Wayne
> >
> Attached, patches for chamfered pads and grid shaped zones.
> --
> Jean-Pierre CHARRAS
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

Follow ups