← Back to team overview

kicad-developers team mailing list archive

Re: [eeschema] Names/descriptions for units

 

Understood - is this the only issue with it? Like I said I'm very happy
for the information to be stored elsewhere, and will adapt my patch as
soon as unit descriptions are part of the format. Can you please email
the list or myself when that happens and let me know?

Kliment

On 27.03.19 16:58, Wayne Stambaugh wrote:
> Hi Kliment,
> 
> I should have been more clear in my previous comments.  There is an
> unwritten policy that anything used internally to KiCad must be part of
> the file format.  The only exception to this is the fields used for
> spice which were held over prior to ng-spice being integrated into
> KiCad.  This is to prevent name space pollution of user field names.
> You patch violates this rule so I cannot accept it.  I will add a unit
> description parameter to the new file format which should resolve your
> issue.
> 
> Cheers,
> 
> Wayne
> 
> On 3/23/2019 7:34 PM, Kliment (Future Bits) wrote:
>> I have a prototype implementation of this now - descriptions are
>> currently taken from fields _UNITDESC_A, _UNITDESC_B etc. The unit
>> descriptions show up when browsing parts in the add dialog, and in the
>> dropdown menu when selecting units in the symbol editor. There is no GUI
>> for setting unit names yet - for the moment you have to add them as
>> normal fields. Patch is attached. All feedback very welcome.
>>
>> Kliment
>>
>> On 22.03.19 21:56, Kliment (Future Bits) wrote:
>>> I don't quite follow - what I'm proposing doesn't require any file
>>> format changes, I was planning to just use the existing field functionality.
>>>
>>> If you want to bake it into the format instead, I'm 100% okay with that,
>>> but I don't think it's necessary. I'll look into implementing the UI
>>> functionality and defer to you on how/where to store the data.
>>>
>>> On 22.03.19 21:45, Wayne Stambaugh wrote:
>>>> Hi Kliment
>>>>
>>>> This cannot happen until the new symbol library file format is
>>>> implemented.  There is a freeze (except for the new bus expansion
>>>> changes) on the current file format.  I will add a unit description
>>>> field for units in the new file format this way you can add a unique
>>>> description for each unit should you desire.
>>>>
>>>> Cheers,
>>>>
>>>> Wayne
>>>>
>>>> On 3/22/19 4:38 AM, Kliment (Future Bits) wrote:
>>>>> Hey,
>>>>>
>>>>> I'm working with a part that has a very large number of
>>>>> non-interchangeable units, each with many pins. For a part like this,
>>>>> it's very difficult to tell which unit is which from the preview. Parts
>>>>> have a description field that is shown in the list, but units don't. For
>>>>> parts with non-interchangeable units, I think a description like that
>>>>> would be very useful. I'd be interested in implementing such a thing.
>>>>> One way I can think of of doing this would be as follows:
>>>>>
>>>>> UI changes:
>>>>> 1. minor change to add part/component selection dialog - use the space
>>>>> to the right of "Unit A" etc to show description, add description to the
>>>>> space after the RD in the bottom part of the dialog
>>>>>
>>>>> 2. change to symbol editor - display unit description after "Unit A" in
>>>>> unit dropdown
>>>>>
>>>>> optionally, 3. make unit dropdown editable, make changes there save to
>>>>> unit name
>>>>>
>>>>> I would propose storing the descriptions in fields with special names of
>>>>> the form UNITDESC_A, _B etc. This requires no change to the existing
>>>>> data model.
>>>>>
>>>>> I'd like some feedback on a) whether this is a good idea, b) whether I'm
>>>>> stepping on anyone's toes if I do it and c) what branch should I base it off
>>>>>
>>>>> Thanks!
>>>>>
>>>>> Kliment
>>>>>
>>>>> _______________________________________________
>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>
>>>>
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>> More help   : https://help.launchpad.net/ListHelp
>>>>
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 



References