kicad-developers team mailing list archive

[John Beard <john.j.beard@xxxxxxxxx>]

Hi Tom,

Ah right. I thought that was a unit test at first because it's under
the "unit tests" section of the Cmake. I don't think it's useless to
have it, as it provides an easy hook for quick testing. Clicking
though the GUI is certainly painful! Since your test is actually a
"utility tool" rather than a unit test, maybe a tool in
qa/pcbnew_tools?

So: qa/pcbnew_tools/tools/hyperlynx_export.cpp

Also would need some command line handling (in and out file, at
least). This avoids expanding build times too much, as you're only
adding a single cpp to the tools executable, not a whole new
statically-linked executable.

Cheers,

John

On Fri, Apr 5, 2019 at 3:55 PM Tomasz Wlostowski
<tomasz.wlostowski@xxxxxxx> wrote:
>
> On 05/04/2019 16:48, John Beard wrote:
> > Hi Tom,
> >
> > Can the hyperlink export test not exist in the existing qa_pcbnew
> > test? The code is all in pcbnew's library, so why not just mirror the
> > source layout and put your test as
> > "qa/pcbnew/exporters/test_export_hyperlynx.cpp"?
> >
> > Otherwise we will eventually have dozens and dozens of tiny unit test
> > executables all in need of CMake files and linking.
> >
> > OTOH, if the hyperlynx stuff was a separate library, then it would
> > make sense to have a separate test exec. At that point, we'd
> > presumably have shared libs anyway.
>
> Hi John,
>
> It's just my internal test program that I accidentally put in the patch.
> I don't like clicking through the pcbnew GUI just to test the exporter.
> There's no formal unit tests for the exporter yet, I'll remove it from
> the final commit.
>
> Tom