← Back to team overview

kicad-developers team mailing list archive

Re: GLM 0.9.9.3 and GLM_FORCE_PURE

 

Rather than remove it completely, how about build option to disable the
SIMD on platforms that don't support it.  Even better, there is probably
a way to query the compiler to check if it supports SIMD and
enable/disable accordingly.

Wayne

On 4/29/19 5:45 AM, Mário Luzeiro wrote:
> Hi Seth, Simon,
> 
> Could you link (eg github mirror, or launchpad) the commit where it was introduced?
> 
> I don't remember, from my side, anything against use SIMD, I prefer to use it if it brings speed.
> All I remember was long time ago someone complain that the KiCad source code was not building on non x86 platforms (eg: ARM, RaspberyPI.. etc) and the 3D viewer was one of the causes because of the use of SIMD..
> 
> I am not sure about how much compatibility of old machines KiCad need to support but I guess you can also set (try) some flags for GLM that limit the intrinsic usage.. but that may cause you issues again. :/
> 
> Mario Luzeiro
> 
> ________________________________________
> From: Kicad-developers <kicad-developers-bounces+mrluzeiro=ua.pt@xxxxxxxxxxxxxxxxxxx> on behalf of Seth Hillbrand <seth@xxxxxxxxxxxxx>
> Sent: 29 April 2019 03:21
> To: Simon Richter
> Cc: KiCad Developers
> Subject: Re: [Kicad-developers] GLM 0.9.9.3 and GLM_FORCE_PURE
> 
> Am 2019-04-28 17:47, schrieb Simon Richter:
>> Hi,
>>
>> it appears we can avoid running into the "constexpr" problem with GLM
>> 0.9.9.3 by either
>>
>>  - deleting "#define GLM_FORCE_PURE" from
>> include/plugins/3dapi/xv3d_types.h
>>
>> or
>>
>>  - switching to C++14 mode
>>
>> Do we actually need the GLM_FORCE_PURE? The commit where it was
>> introduced doesn't explain why, and inhibiting SIMD intrinsics on AMD64
>> which always has at least SSE2 does't really make sense.
> 
> 
> I think Mario is still on the list.  Perhaps he can shed some insight
> here?
> 
> -S
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


Follow ups

References