kicad-developers team mailing list archive

[Henner Zeller <h.zeller@xxxxxxx>]

On Wed, 1 May 2019 at 06:54, Mário Luzeiro <mrluzeiro@xxxxx> wrote:
>
> Hi Henner,
>
> Instead of using SFVEC2UI and hypotf (probably slow), could it be implemented using SFVEC2F and glm::length( a - b ) ?

I didn't know about SFVEC2F or glm::length functions, but then again,
this only happens at preparation time when we set up a new buffer and
blocks to render, so this
happens once whenever the window size changes; everything in that
preparation will probably only take a few microseconds to run even on
an old
machine, so I was not worried either (Whatever glm::length is doing,
will probably just call hyoptf() anyway...)

If there are more elegant ways to describe the same, it should be done
of course.

-h

>
> Mario
> ________________________________________
> From: Henner Zeller <h.zeller@xxxxxxx>
> Sent: 01 May 2019 14:44
> To: John Beard
> Cc: Mário Luzeiro; KiCad Developers
> Subject: Re: [Kicad-developers] PATCH: Raytracing - a more pleasing way sequencing blocks to render ?
>
> On Wed, 1 May 2019 at 06:14, John Beard <john.j.beard@xxxxxxxxx> wrote:
> >
> > On 01/05/2019 13:57, Mário Luzeiro wrote:
> > > Hi John,
> > >
> > > yeah the Morton code is to improve cache hits.
> > >
> > > Regarding the speed test, since OS are multi-tasking there could be some interference on the results so 1s difference is not a very measurable difference ( 4% ).
> > > A possibility would be to run the same scene multiple times and make an average of the times.
> >
> > Sure, it was just a fun observation. It does change a bit from run to
> > run, but I was at least expecting a small penalty. Next up, wipes[1] and
> > then perhaps Snake :-D
> >
> > A more robust benchmarking harness would probably be the way to go if we
> > really were serious about putting the pedal to the metal here.
> >
> > But I think the centre-first approach is certainly better usability, but
> > I'm unsure about the checkerboard.
>
> I agree, without checkerboard it makes it quicker to see what is going
> on in the center. Attached the (even simpler) just spiraling out from
> the center patch.
>
> >
> > Cheers,
> >
> > John
> >
> > [1]: https://www.youtube.com/watch?v=cGqAu9gj_F0