kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #40664
Re: swig 4.0.0 patch
Awesome, thanks! I didn't notice. The fedora nightlies are clearly
failing because of other reasons not related to kicad as such it
seems.
On Tue, 14 May 2019 at 13:29, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>
> Nick,
>
> It already has been merged in the master and 5.1 branches. The commit
> in master is 5685174808f5ca973e916a10f9f93660ee4dc4f2.
>
> Wayne
>
> On 5/14/19 3:47 AM, Nick Østergaard wrote:
> > @Wayne Stambaugh any impediments to getting this merged?
> >
> > On Fri, 10 May 2019 at 21:37, Steven A. Falco <stevenfalco@xxxxxxxxx> wrote:
> >>
> >> Here is the result. Everything passed. The tests run surprisingly quickly.
> >>
> >> <mock-chroot> sh-5.0# make test
> >> Running tests...
> >> /usr/bin/ctest --force-new-ctest-process
> >> Test project /builddir/build/BUILD/kicad-5.1.2
> >> Start 1: qa_python
> >> 1/6 Test #1: qa_python ........................ Passed 1.49 sec
> >> Start 2: common_gerbview
> >> 2/6 Test #2: common_gerbview .................. Passed 0.12 sec
> >> Start 3: common_pcbnew
> >> 3/6 Test #3: common_pcbnew .................... Passed 0.07 sec
> >> Start 4: common_eeschema
> >> 4/6 Test #4: common_eeschema .................. Passed 0.08 sec
> >> Start 5: pcbnew
> >> 5/6 Test #5: pcbnew ........................... Passed 0.16 sec
> >> Start 6: eeschema
> >> 6/6 Test #6: eeschema ......................... Passed 0.23 sec
> >>
> >> 100% tests passed, 0 tests failed out of 6
> >>
> >> Steve
> >>
> >>
> >> On 5/10/19 1:44 PM, Steven A. Falco wrote:
> >>> I'll run that. Please give me a half hour or so, because I have to regenerate my rawhide build area - the "mock" tool ordinarily deletes everything as soon as a build completes.
> >>>
> >>> Steve
> >>>
> >>> On 5/10/19 1:37 PM, Wayne Stambaugh wrote:
> >>>> `make test` will run all of the qa tests. The python qa test is the
> >>>> first one run. It's not comprehensive but it will let you know if
> >>>> you've completely broken python support.
> >>>>
> >>>> On 5/10/19 1:32 PM, Steven A. Falco wrote:
> >>>>> I used the footprint wizard to create some footprints. I'll be happy to run qa tests - is there a "make" target for them? I've never run them before...
> >>>>>
> >>>>> Steve
> >>>>>
> >>>>> On 5/10/19 1:21 PM, Wayne Stambaugh wrote:
> >>>>>> Hi Steve,
> >>>>>>
> >>>>>> Did you actually test and confirm that the python scripting is working?
> >>>>>> I ran a few of the default scripts just as quick and dirty test along
> >>>>>> with the qa tests. If the qa tests work for you, I will go ahead and
> >>>>>> merge the patch.
> >>>>>>
> >>>>>> Wayne
> >>>>>>
> >>>>>> On 5/10/19 1:09 PM, Steve Falco wrote:
> >>>>>>> Should have mentioned that rawhide is using swig 4.0.0.
> >>>>>>>
> >>>>>>> On Fri, May 10, 2019, 1:06 PM Steve Falco <stevenfalco@xxxxxxxxx
> >>>>>>> <mailto:stevenfalco@xxxxxxxxx>> wrote:
> >>>>>>>
> >>>>>>> I am now able to build on rawhide with this patch. It works for me.
> >>>>>>>
> >>>>>>> Steve
> >>>>>>>
> >>>>>>> On Fri, May 10, 2019, 1:04 PM Wayne Stambaugh <stambaughw@xxxxxxxxx
> >>>>>>> <mailto:stambaughw@xxxxxxxxx>> wrote:
> >>>>>>>
> >>>>>>> Has anyone with swig 4 tested this patch yet. I tested it and it
> >>>>>>> appears not to break anything with swig < 4. If it works for
> >>>>>>> swig 4, we
> >>>>>>> should get this merged so platforms using swig 4 wont have to
> >>>>>>> downgrade
> >>>>>>> to build KiCad.
> >>>>>>>
> >>>>>>> Wayne
> >>>>>>>
> >>>>>>> On 5/9/19 3:58 AM, mdoesbur@xxxxxxxxx
> >>>>>>> <mailto:mdoesbur@xxxxxxxxx> wrote:
> >>>>>>> > Sorry about that, here's the patch
> >>>>>>> >
> >>>>>>> >
> >>>>>>> >
> >>>>>>> >
> >>>>>>> > _______________________________________________
> >>>>>>> > Mailing list: https://launchpad.net/~kicad-developers
> >>>>>>> > Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >>>>>>> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >>>>>>> > Unsubscribe : https://launchpad.net/~kicad-developers
> >>>>>>> > More help : https://help.launchpad.net/ListHelp
> >>>>>>> >
> >>>>>>>
> >>>>>>> _______________________________________________
> >>>>>>> Mailing list: https://launchpad.net/~kicad-developers
> >>>>>>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >>>>>>> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>>>>>> More help : https://help.launchpad.net/ListHelp
> >>>>>>>
> >>>>>>
> >>>>>
> >>>>
> >>>
> >>>
> >>
> >>
> >> _______________________________________________
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help : https://help.launchpad.net/ListHelp
Follow ups
References
-
swig 4.0.0 patch
From: mdoesbur, 2019-05-09
-
Re: swig 4.0.0 patch
From: Wayne Stambaugh, 2019-05-10
-
Re: swig 4.0.0 patch
From: Steve Falco, 2019-05-10
-
Re: swig 4.0.0 patch
From: Steve Falco, 2019-05-10
-
Re: swig 4.0.0 patch
From: Wayne Stambaugh, 2019-05-10
-
Re: swig 4.0.0 patch
From: Steven A. Falco, 2019-05-10
-
Re: swig 4.0.0 patch
From: Wayne Stambaugh, 2019-05-10
-
Re: swig 4.0.0 patch
From: Steven A. Falco, 2019-05-10
-
Re: swig 4.0.0 patch
From: Steven A. Falco, 2019-05-10
-
Re: swig 4.0.0 patch
From: Nick Østergaard, 2019-05-14
-
Re: swig 4.0.0 patch
From: Wayne Stambaugh, 2019-05-14