← Back to team overview

kicad-developers team mailing list archive

Re: [Patch] Fixes for the github 3D library fetching dialog

 

It looks like this was the same one that went to the bug tracker.

I tested it and pushed earlier this morning.

-Seth

Am 2019-05-23 12:55, schrieb Wayne Stambaugh:
JP,

This patch looks correct to me but this is your code so please take a
look at this to see if it makes sense to you when you get a chance.

Thanks,

Wayne

On 5/3/19 8:05 PM, Ian McInerney wrote:
The attached patch modifies the behavior of the wizard for fetching the
3d libraries from github to fetch the list of libraries if the URL is
modified by the user (e.g. if they go to page 2, then back to page 1 and modify the URL it will now fetch the library list for the modified URL).
It also fixes an issue where the library list was not populating when
first visiting the second page (it would only populate if you tried
searching or went back to page 1 and then page 2).

-Ian

_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Follow ups

References