← Back to team overview

kicad-developers team mailing list archive

Re: Via stitching



On 5/22/19 5:39 AM, John Beard wrote:
> On 20/05/2019 23:48, Frank Severinsen wrote:
>> When using clang-format on the entire file, it more or less changed
>> every line in one way or another.
>> should this be committed as well or is git clutter worse than
>> codingstyle issues?
> You should not commit unrelated formatting clutter in the same commit as
> actual code changes. Just format the changed bits. If that's too
> inconsistent, either reformat as a separate commit, or match the
> existing style in the area, even if it's "wrong".
> The trick here is to use git-clang-format. This will only format the
> lines you have changed. There are instructions in the developer
> documentation[1], a git-hook to report errors when you commit, and a
> script to help you fix it.
> @Wayne: I have a patch here for the formatting document to add some
> aliases to make it easier. It finally dawned on me that we already
> distribute aliases for the 'fixes' alias, so let's do it for the
> formatting too!

Looks good to me.


> [1]:
> http://docs.kicad-pcb.org/doxygen/md_Documentation_development_coding-style-policy.html
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp