← Back to team overview

kicad-developers team mailing list archive

Re: Patch set: Display Origin Transforms updates



I hate to ask you to rebase again but there has been so much activity
recently that several of you original patches no longer apply cleanly.
Please rebase and resubmit the original patch set when you get a chance.

Lead Devs,

Let's try to be kind to Reece so I can get this merged.  As soon as he
resubmits his rebased patch set, please hold off on pushing any new
changes until I can get it merged.  Otherwise we will continue this
never ending loop.



On 5/23/2019 9:49 PM, Reece R. Pollack wrote:
> I've attached a Zip file containing additional patches to be applied on
> top of the previous set.
> The first three patch files address Wayne's code review comments. If
> anyone else had comments I didn't see them.
> The fourth patch file provides support for Bezier control points. A big
> "thank you" goes to Seth Hillbrand for providing the example PCB file,
> which was very helpful.
> The remaining two patch files provide support for the "Move Exactly",
> "Move Item", and "Create Array" dialogs which the first patch set didn't
> address.
> I think this covers all of the places where Pcbnew displays coordinates
> and offsets to the user. If anyone sees something that is either not
> adjusted for the user-selected origin, or has the wrong sign, please let
> me know!
> -Reece
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp