← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Crash Reporter



On 5/28/2019 12:13 PM, Tomasz Wlostowski wrote:
> On 27/05/2019 17:39, Seth Hillbrand wrote:
>> On 2019-05-02 17:41, Tomasz Wlostowski wrote:
>>> On 02/05/2019 07:06, Wayne Stambaugh wrote:
>>>> By chance did you build with OCC instead of OCE which is what I am
>>>> using?  Please fix this when you get a chance, I would like to get this
>>>> merged but I need to be able to test.
>>>> Why did your remove the GDK_* and GTK_* environment variables from
>>>> APP_KICAD ctor?  Wont this break the compatibility support we currently
>>>> have?
>>>> I noticed quite a bit of trailing whitespace in patches 5 and 10 so that
>>>> will need to be cleaned up.
>>>> Please send me the link to your remote branch for this.  It's easier for
>>>> me to just pull a branch into my repo than apply a large patch set using
>>>> `git am`.
>>> Hi Wayne,
>>> Probably I screwed something up while rebasing the code on top of fresh
>>> master. I'll check/fix the errors in the evening.
>>> Greetings from CO,
>>> Tom
>> Ping!
> Done (tom-crash-reporter-may27 on my Github)!
> Tom

What is your github user name?  I'm have trouble finding your crash
reporter repo to test.



Follow ups