kicad-developers team mailing list archive

[Jeff Young <jeff@xxxxxxxxx>]

OK, that’s really bizarre as that change /removes/ a reference to EDA_3D_VIEWER rather than adds one.

Still, it’s safe enough to revert (there’s no real change; it just used to open-code a routine it could have been calling).

I’ll merge fixes….

Cheers,
Jeff.

> On 4 Jun 2019, at 16:19, jp charras <jp.charras@xxxxxxxxxx> wrote:
> 
> Le 04/06/2019 à 16:44, Wayne Stambaugh a écrit :
>> Jeff,
>> 
>> The fix didn't work for me.  Now I'm getting this error:
>> 
>> [ 97%] Linking CXX executable qa_pcbnew
>> /usr/bin/ld: ../../common/libpcbcommon.a(pcb_base_frame.cpp.o): in
>> function `PCB_BASE_FRAME::Update3DView(bool, wxString const*)':
>> /home/wayne/src/kicad-trunk/pcbnew/pcb_base_frame.cpp:131: undefined
>> reference to `EDA_3D_VIEWER::NewDisplay(bool)'
>> /usr/bin/ld: ../../common/libpcbcommon.a(pcb_base_frame.cpp.o): in
>> function `PCB_BASE_FRAME::CreateAndShow3D_Frame()':
>> /home/wayne/src/kicad-trunk/pcbnew/pcb_base_frame.cpp:395: undefined
>> reference to `EDA_3D_VIEWER::EDA_3D_VIEWER(KIWAY*, PCB_BASE_FRAME*,
>> wxString const&, long)'
>> collect2: error: ld returned 1 exit status
>> make[2]: *** [qa/pcbnew/CMakeFiles/qa_pcbnew.dir/build.make:759:
>> qa/pcbnew/qa_pcbnew] Error 1
>> make[1]: *** [CMakeFiles/Makefile2:3874:
>> qa/pcbnew/CMakeFiles/qa_pcbnew.dir/all] Error 2
>> make: *** [Makefile:163: all] Error 2
>> 
>> 
> 
> 
> Looks like it is the change in pcbnew/files.cpp (and only this change)
> that created the issue (the dynamic cast itself does not create issue).
> When I revert the change in pcbnew/files.cpp, the link is OK.
> 
> 
> -- 
> Jean-Pierre CHARRAS
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>