kicad-developers team mailing list archive

[Jeff Young <jeff@xxxxxxxxx>]

CMake is black magic to me.  I wouldn’t know if this were the best thing since sliced bread or the return of the plague. ;)

Cheers,
Jeff.


> On 11 Jun 2019, at 16:11, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
> 
> Seppe,
> 
> Your patch looks good to me.  Any MacOS devs care to comment?
> 
> Cheers,
> 
> Wayne
> 
> On 6/11/19 10:46 AM, Seppe Stas wrote:
>> Hey Wayne
>> 
>> I attached my patch (generated with `git format-patch --attach
>> origin/master`) to my last email as
>> per http://www.kicad-pcb.org/contribute/developers/#_submitting_patches.
>> I have a feeling Gmail might not like the mail headers in the patch.
>> 
>> I created a new patch without the --attach option and added it to this
>> email (I am more used to this patch format and I believe it worked in
>> the past).
>> 
>> Greetings
>> Seppe
>> 
>> On Tue, Jun 11, 2019 at 4:27 PM Wayne Stambaugh <stambaughw@xxxxxxxxx
>> <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>> wrote:
>> 
>>    Seppe,
>> 
>>    I don't understand why your emails keep ending up on the moderated list
>>    but something strange is going on.  I had to moderate this one as well.
>>     Please attach your patch (created using `git format-patch`) so it can
>>    be reviewed and commented on.
>> 
>>    Cheers,
>> 
>>    Wayne
>> 
>>    On 6/11/19 10:17 AM, Seppe Stas wrote:
>>> Hey
>>> 
>>> I closed the merge request on Launchpad and re-attached the patch and
>>> before and after screenshots (the after being built from a dirty
>>    master
>>> branch) to this mail:
>>> 
>>> Before:
>>> [image: Screenshot 2019-06-05 at 22.46.43.png]
>>> After:
>>> [image: Screenshot 2019-06-05 at 22.46.54.png]
>>> 
>>> As you can see, having this version information displayed in Spotlight
>>> makes choosing the correct KiCad version a lot easier. It works
>>    for the
>>> other apps (EEschema, PCBNew, ...) as well.
>>> 
>>> Greetings
>>> Seppe
>>> 
>>> On Tue, Jun 11, 2019 at 2:50 PM Seth Hillbrand <seth@xxxxxxxxxxxxx <mailto:seth@xxxxxxxxxxxxx>
>>    <mailto:seth@xxxxxxxxxxxxx <mailto:seth@xxxxxxxxxxxxx>>> wrote:
>>> 
>>>> Hi Seppe-
>>>> 
>>>> I see this e-mail.  Perhaps it was a launchpad hiccup.
>>>> 
>>>> I've added Adam to the code review at [1].  Would you mind re-sending
>>>> the images to the list?
>>>> 
>>>> Thanks-
>>>> Seth
>>>> 
>>>> [1]
>>    https://code.launchpad.net/~seppestas/kicad/+git/kicad/+merge/368644 <https://code.launchpad.net/~seppestas/kicad/+git/kicad/+merge/368644>
>>>> 
>>>> On 2019-06-11 05:23, Seppe Stas wrote:
>>>>> Hey
>>>>> 
>>>>> I'm not sure if this email got ignored or if it got rejected by some
>>>>> mailing system, but it does not seem to show up in the mailing list
>>>>> archive
>>>>> <https://lists.launchpad.net/kicad-developers/date.html <https://lists.launchpad.net/kicad-developers/date.html>>.
>>>>> 
>>>>> Maybe now it works?
>>>>> 
>>>>> Seppe
>>>>> 
>>>>> On Wed, Jun 5, 2019 at 10:55 PM Seppe Stas <seppestas@xxxxxxxxx <mailto:seppestas@xxxxxxxxx>
>>    <mailto:seppestas@xxxxxxxxx <mailto:seppestas@xxxxxxxxx>>> wrote:
>>>>> 
>>>>>> Hey guys and girls (probably mostly Adam in particular)
>>>>>> 
>>>>>> Attached is a patch that sets the version in all MacOS apps to the
>>>>>> value
>>>>>> of KICAD_VERSION, i.e the value of git describe. See commit message
>>>>>> for
>>>>>> more technical details. This version show up when e.g launching the
>>>>>> app
>>>>>> using spotlight, and during the migration period from KiCad 4
>>    to KiCad
>>>>>> 5
>>>>>> (that is still going on) I really miss(ed) this feature, since
>>    I have
>>>>>> 3
>>>>>> different versions of KiCad on my system (4, 5 and master).
>>>>>> 
>>>>>> See attached screenshots:
>>>>>> [image: Screenshot 2019-06-05 at 22.46.54.png]
>>>>>> [image: Screenshot 2019-06-05 at 22.46.43.png]
>>>>>> 
>>>>>> I tested this patch on both the latest master (6f8a0a4ee) and
>>    the 5.1
>>>>>> branch (cd6da987c). I hope you consider adding it to a KiCad 5
>>    release
>>>>>> so I
>>>>>> can use it when KiCad 6 comes out. (I hope I finished migrating to
>>>>>> KiCad 5
>>>>>> by then).
>>>>>> 
>>>>>> Note that in order to update this value, CMake has to be
>>    re-run, but I
>>>>>> would not expect this to be a big problem since I assume the
>>    releases
>>>>>> are
>>>>>> always built from scratch.
>>>>>> 
>>>>>> Greeting
>>>>>> Seppe Stas
>>>>>> 
>>>>> 
>>>>> _______________________________________________
>>>>> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>    <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>>>>> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>>>> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
>>>> 
>>> 
>>> 
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>    <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>>> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
>>> 
>> 
>>    _______________________________________________
>>    Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>    Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>    <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>>    Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>    More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
>> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>