kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

On 6/14/19 10:10 AM, Jeff Young wrote:
> Hi Wayne,
> 
>> On 14 Jun 2019, at 14:42, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>>
>> On 6/14/19 7:59 AM, Jeff Young wrote:
>>> My plan had been to support both two-step (first selects tool; second draws object) and immediate (always draws) actions, and let the user assign the hotkey to the one they prefer.
>>>
>>> But I’m discovering a bunch of things that are unsettling about it.  It hard to discover if we chose the default option that’s not the one you wanted.  Which actions does the Place menu show?  It kind of has to do a select-tool action, but that’s inconsistent if the tool is already selected.  And to make matters worse, you’d really like to show the immediate hotkeys there because that’s the first place people will look.
>>
>> This was why I suggested that we have separate hotkey vs menu
>> accelerator paradigm but that was dismissed.  Your statement above
>> illustrates why they are separate actions.  I'm not sure what that
>> answer is here but we seem no closer to solving the issue.
>>
>>>
>>> Then I had an epiphany: it’s easy enough to distinguish select-tool from draw-object contextually (did they use the menu or not?); the real differentiator between two-step and immediate is whether or not the tool remains selected after the object is drawn.
>>
>> How about this?  If the previous tool was the select tool, then the
>> hotkey selected drawing tool remains active until dismissed.  If the
>> previous tool was not the selection tool, do a one shot action and
>> return to the previously selected tool when the hotkey action is
>> complete.  This would most closely mimic the legacy tool behavior which
>> a significant number of users seem to prefer.
> 
> I think I’d find it annoying that it didn’t work the same when the select tool was active.  Is there a reason to make it special?

Sorry, I didn't explain this very well.  In the legacy toolset, when an
immediate action hotkey was pressed (move, rotate, mirror, etc) and any
tool except the selection tool was active, the previous tool was still
active after the action was performed.  With the new tool framework,
when an immediate action hotkey is pressed (move, rotate, mirror, etc),
the current tool is aborted and selection tool is enabled after the
action is complete.  I would prefer that the current tool remain active
after the immediate action was performed.

> 
> Cheers,
> Jeff.
> 
>>
>>>
>>> So how about if we add a preference for that instead?
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>