← Back to team overview

kicad-developers team mailing list archive

Re: Pcbnew zoom to fit behavior changed


Hi Andrew,

Yes it was basically reverted (keeping a few fixes) based on feedback and
Too many people preferred the old behavior.


On Fri, Jun 14, 2019 at 6:20 PM Andrew Lutsenko <anlutsenko@xxxxxxxxx>

> It appears this was undone? Zoom-to-fit ignores the worksheet again.
> Curious for the reasoning behind that decision.
> On Mon, May 27, 2019 at 4:22 PM Andrew Lutsenko <anlutsenko@xxxxxxxxx>
> wrote:
>> Thanks Jon, now this makes sense.
>> With ability to disable worksheet in items panel to revert to old
>> behavior I am mostly satisfied. Ideally I wouldn't have to do that since
>> honestly the only time I pay attention to worksheet is in the very last
>> stage of the project when gerbers are already done and I just fill in the
>> metadata for publishing.
>> But I can see the consistency argument and unchecking one tick box at the
>> start of the project is certainly not a big deal.
>> Andrew
>> On Mon, May 27, 2019 at 4:10 PM Jon Evans <jon@xxxxxxxxxxxxx> wrote:
>>> Hi Andrew,
>>> This was intentional but I'm open to input on this.
>>> The previous behavior would zoom to fit all items (including items on
>>> hidden layers), or the worksheet if there are no items.
>>> The new behavior zooms in on all visible items.
>>> So, if you don't want to zoom to fit the worksheet, you can just turn
>>> off the worksheet layers (in the Items panel)
>>> Is that enough of an option for you?
>>> We could go back to the behavior of "only consider the worksheet if
>>> there are no items" but it made less sense to me.
>>> (The relevant commit is 549b767)
>>> -Jon
>>> On Mon, May 27, 2019 at 7:04 PM Andrew Lutsenko <anlutsenko@xxxxxxxxx>
>>> wrote:
>>>> Hi all,
>>>> On current master (50d2aaa97) I noticed that zoom to fit action in
>>>> pcbnew now zooms on the whole drawing, including the template border
>>>> instead of just on the board.
>>>> Is that intentional? If so can we have an option in preferences to
>>>> revert to old behavior?
>>>> It is much more sensible in my opinion and I use that function a lot,
>>>> I'm sure others do too.
>>>> Regards,
>>>> Andrew
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>> More help   : https://help.launchpad.net/ListHelp