kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Wire, bus, graphic line, and sheet but only when enabled with an
immediate hotkey.  When I enable the tool via a toolbar button or
selecting a menu entry, then the behavior is the same as the legacy tool
framework.  It really should not matter how a tool is enabled, only the
initial behavior.

On 6/18/2019 7:53 AM, Jeff Young wrote:
> Hi Wayne,
> 
> I wrote the whole PushTool/PopTool stuff exactly for that case.  Which action in particular is going back to the SelectionTool?
> 
> (Note that some are “supposed” to.  If you click on a tool in the toolbar, or select it from the Place menu, then cancelling should take you back to the SelectionTool.  However, if you use the context menu or a hotkey, it should push and then pop the drawing tool.  Not to say that it’s not buggy, or that the design behaviour isn’t optimal.)
> 
> Cheers,
> Jeff.
> 
> PS: should I make the same changes to Pcbnew, or should be await more feedback?  (Feedback on the forums has been uniformly positive so far, but pretty sparse with only 3 likes.)
> 
> 
>> On 18 Jun 2019, at 12:48, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>>
>> Hey Jeff,
>>
>> I spent some time this morning playing around with the "immediate"
>> hotkeys in Eeschema and it's better but there is still one annoying
>> difference from the legacy behavior.  When cancelling (escape key) a
>> drawing in progress, the drawing is aborted, the current tool is
>> canceled, and the selection tool is enable.  The legacy behavior was
>> abort the drawing in progress and keep the current tool enabled.  The
>> current tool would only be canceled when it was not busy drawing
>> something.  It's rather cumbersome to have to keep enabling the drawing
>> tool every time you exit a drawing when you make a mistake.
>>
>> Cheers,
>>
>> Wayne
>>
>> On 6/15/2019 3:45 PM, Jeff Young wrote:
>>> I’ve checked in code which makes the drawing hotkeys “immediate” in Eeschema and the Symbol Editor.  It was more involved than I was expecting, so there may be some nasty surprises.
>>>
>>> I folks like it, I can apply the same architecture to Pcbnew.
>>>
>>> Cheers,
>>> Jeff.
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>