kicad-developers team mailing list archive
Mailing list archive
Re: Immediate mode actions
Jeff Young <jeff@xxxxxxxxx>
Wayne Stambaugh <stambaughw@xxxxxxxxx>
Tue, 18 Jun 2019 16:07:40 -0400
addr=stambaughw@xxxxxxxxx; prefer-encrypt=mutual; keydata= mQGiBEM0hxQRBAC2fNh3YOVLu1d5GZ0SbrTNldGiGnCJPLqzEnqFX9v6jmf33TMt6EmSLkl6 Wtfkoj0nVwKxcYmJkA8DX0QAokBkwNIzhSsBzQvthBLIk/5LnPVVKrEXOcL4mUyH1doKlkaE slgJozNa6Av+oavcvD02o1zJOloBbaHlNlyRt7fKswCgtIFlVjWggVH/15KfWk+Qo5JVPbME AIUBAQyL2OAx0n60AWec2WHnO9buHuG0ibtICgUMkE+2MRmYyKwYRdyVwGoIUemFuOyHp0AJ InX4T+vy2E7vkwODqjtMLfIoRkokW74Fi4nrvjlhOAw/vdq/twLbAmR9MOfPTpR4y7kQy1O2 /n+RkkRvh26vTzfbQmrH7cBJhk6aA/9Uwvu3E4zNJgHVZeS0HyWtmR1eOPPRbnkPgJTToX5O KMKzTJI/FX6kT7cFoCamitHrW3BJP4Dx+cMMsa47EGxqVTdbVJ4LjogsXTXxb+0Fn1u4zBdx x3Cer6O7+hqWy7zvpzeC6nSREjqDKa5CgHtv/GLm5uFPOmsjAsnHj2tlBrQmV2F5bmUgU3Rh bWJhdWdoIDxzdGFtYmF1Z2h3QGdtYWlsLmNvbT6IeAQTEQIAOBYhBOffs6CbblRzBkv33BtR cWlZ+CReBQJbFBS2AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEBtRcWlZ+CReMI8A nRbrLkzp7+c2f0vX7sfg4ICX8LAKAJ9uClo4uJajmZa5zZrL2nKdZlUwIrkCDQRDNIcxEAgA gCru+3/aOC6RCjpvYC72wY+d5SmHphC6yeiV2/mOumyt5MLo/Ps2GznZr11JspqFk5K/Zpvp MMLqqjDZ39+50a2iKRQFJ6NlK+hJWMmj6eJygQrCwYo3Gjc6CqfrqUv+8VSnf/i5sIZmtOVA 4ZjML18MuBvMSsNdVLFJd5HNnYb1iOECpvqdPVh/21LLCEw7MUUGGnHBhCrmk2aJe5hFmcSN g4ldBcXrgMQBwf7aMVoobXBMFDb/IENByXn0llB7Gr2IFMRmNS9/p8s/II1Yl2bTqyX4FSz8 cfn7C9KEz7faZ7wzAcpwHFC/zs3JoAjJ0IEKdNUpIwAlKMzT3CzctwADBQf/cxpG28MKyrqk nNmq/8LQLy+x6FSYXBLjxQz9BiBNYeesDZQ6J5UbL1mjpJzMa5tLZypPYo4bbGyR22hrbyDF K7m6AcVaMIJKl98g4ukMutFfAJyRDaREH5Zl/X1P4u1Z/yaAIy9mKaNbaK1/5djNJ5wCTFen TUgAp9xdc30kGkFDdLJFp5uxDY4P0vaZiZdjUCvDM3Zjv5IzpNOfxVqTUBQNUP/BnnKhkk0p DTD6s3X8S+D0rOtEBQ8K0cwERI/E8EFa8nj0TNw4e2MYGR8wg+SxqJ7z5f0zPY0bO6G9DDFB wYCqzzPWGqdAh9vA5971TAbPERtdFybhkurozp2SfYhJBBgRAgAJBQJDNIcxAhsMAAoJEBtR cWlZ+CResHUAniULLCWiT26ieRTl7N2vS6vBo/DuAJ4m7Ss/gyiW6ybTn1ctDXAUgm2QVQ==
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1
Better but now the second (third, fourth, fifth, ...) escape key does
not exit after the first escape key cancels the immediate action. Using
the toolbar or menu to select the tool does work correctly. One other
new oddity is that selecting a second tool using the toolbar or menu
will result in the previous tool being selected rather than the
selection tool after escape is pressed when the tool is idle. I think
you may have gone too far the other way.
On 6/18/19 3:52 PM, Jeff Young wrote:
> Hi Wayne,
> I checked in some new code. Give it a go when you get a chance.
>> On 18 Jun 2019, at 13:01, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>> Wire, bus, graphic line, and sheet but only when enabled with an
>> immediate hotkey. When I enable the tool via a toolbar button or
>> selecting a menu entry, then the behavior is the same as the legacy tool
>> framework. It really should not matter how a tool is enabled, only the
>> initial behavior.
>> On 6/18/2019 7:53 AM, Jeff Young wrote:
>>> Hi Wayne,
>>> I wrote the whole PushTool/PopTool stuff exactly for that case. Which action in particular is going back to the SelectionTool?
>>> (Note that some are “supposed” to. If you click on a tool in the toolbar, or select it from the Place menu, then cancelling should take you back to the SelectionTool. However, if you use the context menu or a hotkey, it should push and then pop the drawing tool. Not to say that it’s not buggy, or that the design behaviour isn’t optimal.)
>>> PS: should I make the same changes to Pcbnew, or should be await more feedback? (Feedback on the forums has been uniformly positive so far, but pretty sparse with only 3 likes.)
>>>> On 18 Jun 2019, at 12:48, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>>>> Hey Jeff,
>>>> I spent some time this morning playing around with the "immediate"
>>>> hotkeys in Eeschema and it's better but there is still one annoying
>>>> difference from the legacy behavior. When cancelling (escape key) a
>>>> drawing in progress, the drawing is aborted, the current tool is
>>>> canceled, and the selection tool is enable. The legacy behavior was
>>>> abort the drawing in progress and keep the current tool enabled. The
>>>> current tool would only be canceled when it was not busy drawing
>>>> something. It's rather cumbersome to have to keep enabling the drawing
>>>> tool every time you exit a drawing when you make a mistake.
>>>> On 6/15/2019 3:45 PM, Jeff Young wrote:
>>>>> I’ve checked in code which makes the drawing hotkeys “immediate” in Eeschema and the Symbol Editor. It was more involved than I was expecting, so there may be some nasty surprises.
>>>>> I folks like it, I can apply the same architecture to Pcbnew.
>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>> More help : https://help.launchpad.net/ListHelp
>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>> More help : https://help.launchpad.net/ListHelp