← Back to team overview

kicad-developers team mailing list archive

Re: Bug created by commit 6253b44f20


Hi JP,

No need to file a bug.  This is the third or fourth corner case I’ve run in to which tells me I need a more robust design.  I’m going to remove SetTool() in favour of always using Push/Pop.


> On 27 Jun 2019, at 08:58, jp charras <jp.charras@xxxxxxxxxx> wrote:
> Hi Jeff,
> Your fix (commit 6253b44f20) is incorrect and creates a new and more
> serious bug:
> * When the highlight tool or the delete tool is activated (checked) the
> first time you click on the canvas, the previous tool is checked with a
> very strange behavior (at least on W7 32 bits) depending on the previous
> tool.
> for instance after activating the delete tool:
> - if the previous tool was the Select tool (arrow tool), the select tool
> is displayed as checked, but the delete tool is still activated (but non
> checked): you can delete items.
> - if the previous tool was the Add symbol tool, as soon as you try to
> delete an highlighted item, the item is not deleted, but instead the Add
> symbol dialog is opened.
> I can fill a bug if you want.
> -- 
> Jean-Pierre CHARRAS
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp