← Back to team overview

kicad-developers team mailing list archive

Re: [Patch] Cleanup of cmake python flag dependency handling


Hi Ian,

I merged your patch into the master and 5.1 branches of KiCad.  Thank
you for your contribution to KiCad.



On 6/20/2019 12:37 PM, Ian McInerney wrote:
> Based on the previous discussion on the list about the cmake handling
> for the python flags, I have made the attached patch for master. In it I
> have cleaned up how all the KICAD_SCRIPTING_* flags are handled in the
> main cmake file so that now the flag KICAD_SCRIPTING acts as a global
> off switch for all python support (it will set all other flags to OFF
> when it is set to OFF by the user). I have also added version checking
> to the wxPython detection portion, so that it now verifies that Phoenix
> was actually found when it was requested, and that the classic interface
> was found if it was requested. A mismatch in the wxPython requested
> flavor and found flavor is a fatal error for the process so the user has
> to sort out what is happening with their versioning.
> I do not believe these changes will break existing build processes,
> since they should already have the flags in the valid combinations and
> the defaults for the flags remain the same.
> -Ian
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp