← Back to team overview

kicad-developers team mailing list archive

[Patch] Update libngspice build script

 

The get_libngspice script in the build_tools directory is out of date (it
was still pointing to a 2016 version). I don't know how many people
actually use it, but I do, so I have updated it to ngspice-30. The attached
patch does this.

-Ian
From 1da88569213179788bf704ef0676c77a1a1f44a5 Mon Sep 17 00:00:00 2001
From: Ian McInerney <Ian.S.McInerney@xxxxxxxx>
Date: Sun, 30 Jun 2019 16:10:45 +0100
Subject: [PATCH] Update ngspice build tool script to ngspice-30

---
 scripting/build_tools/get_libngspice_so.sh | 25 ++++++++++++++++------
 1 file changed, 19 insertions(+), 6 deletions(-)

diff --git a/scripting/build_tools/get_libngspice_so.sh b/scripting/build_tools/get_libngspice_so.sh
index b1d9ebb35..5f6d1f6a1 100755
--- a/scripting/build_tools/get_libngspice_so.sh
+++ b/scripting/build_tools/get_libngspice_so.sh
@@ -1,10 +1,16 @@
 #!/bin/bash
 
 # author: Maciej Suminski <maciej.suminski@xxxxxxx>
-# contributors: madworm
+# contributors: madworm, imcinerney
 
-SNAPSHOT_REV="99a20162d5038a328d335d11da69c9eee0549fdc"
-SNAPSHOT_GIT="git://git.code.sf.net/p/ngspice/ngspice"
+# Set to 1 to pull the tag given by NGSPICE_GIT_TAG
+# Set to 0 to pull the commit with the has given by NGSPICE_GIT_HASH
+USE_GIT_TAG=1
+
+NGSPICE_GIT_TAG="ngspice-30-2"
+NGSPICE_GIT_HASH="d6f5a32c93a46b6dec8a5097533ddf682cecf2d9"
+
+NGSPICE_GIT="git://git.code.sf.net/p/ngspice/ngspice"
 
 BUILD_DIR="/tmp/libngspice_so"
 SRC_DIR="${BUILD_DIR}/ngspice"
@@ -73,13 +79,13 @@ cd "${BUILD_DIR}" || exit
 echo "libngspice (for KiCad) builder v1.2"
 echo "(c) CERN 2016"
 echo "author: Maciej Suminski <maciej.suminski@xxxxxxx>"
-echo "contributors: madworm"
+echo "contributors: madworm, imcinerney"
 echo
 echo "PREREQUISITES: autoconf automake bison flex gcc git libtool make"
 echo
 
 echo "*** Downloading ngspice source code.. ***"
-git clone ${SNAPSHOT_GIT}
+git clone ${NGSPICE_GIT}
 
 if [ $? != 0 ]; then
     echo "*** An error occurred when downloading the source code ***"
@@ -94,7 +100,14 @@ else
 fi
 
 echo "*** Building libngspice shared library.. ***"
-git checkout ${SNAPSHOT_REV}
+if [ $USE_GIT_TAG == 1 ]; then
+    echo "*** Checking out tag ${NGSPICE_GIT_TAG} ***"
+    git checkout tags/${NGSPICE_GIT_TAG}
+else
+    echo "*** Checking out git commit ${NGSPICE_GIT_HASH} ***"
+    git checkout ${NGSPICE_GIT_HASH}
+fi
+
 ./autogen.sh
 ./configure --with-ngshared --enable-xspice --enable-cider ${CFG_OPTIONS}
 make
-- 
2.21.0


Follow ups