← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH 1/1] Fix build order for generated headers and sources

 

Hi Simon-

Thanks for the patch! Unfortunately, I get a build error on Linux Debian:

[ 38%] Building CXX object eeschema/CMakeFiles/eeschema_kiface_objects.dir/widgets/symbol_tree_pane.cpp.o /home/seth/code/kicad/kicad_bare/eeschema/dialogs/panel_sym_lib_table.cpp:29:10: fatal error: lib_table_lexer.h: No such file or directory
 #include <lib_table_lexer.h>
          ^~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [eeschema/CMakeFiles/eeschema_kiface_objects.dir/build.make:921: eeschema/CMakeFiles/eeschema_kiface_objects.dir/dialogs/panel_sym_lib_table.cpp.o] Error 1

This is with make -j42.  Let me know if you'd like a full build log.

Best-
Seth

On 2019-07-01 11:34, Simon Richter wrote:
This changes make_lexer() so that it no longer generates a custom target but instead attaches the generated files to an existing one (so the first argument now is the name of an existing library or executable, and it needs
to come after the add_library/add_executable call).

The generated source is no longer listed in the project sources, as it is
added by the function. The files are generated in the build tree rather
than the source tree, and the directory is added to the include path for the respective project as well as exported to projects linking against it.

Generated files in subdirectories are somewhat supported, but need to be referenced with the same name as they were generated (i.e. including the
subdirectory name).

---
 CMakeModules/Functions.cmake              | 27 ++++--------
 CMakeModules/TokenList2DsnLexer.cmake     |  2 +-
common/CMakeLists.txt | 73 +++++++++----------------------
 common/page_layout/page_layout_reader.cpp |  2 +-
 common/page_layout/ws_data_model_io.cpp   |  2 +-
 eeschema/CMakeLists.txt                   | 47 ++++++++------------
 eeschema/dialogs/dialog_bom.cpp           |  2 +-
 new/CMakeLists.txt                        | 26 +++++------
 pcb_calculator/CMakeLists.txt             | 14 ++----
 pcbnew/CMakeLists.txt                     | 27 ++++--------
 pcbnew/specctra_import_export/specctra.h  |  2 +-
 qa/eeschema/CMakeLists.txt                |  5 +--
 12 files changed, 79 insertions(+), 150 deletions(-)


_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Follow ups

References