← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH 0/9] MSVC build support

 

Simon,

What is the minimum version of MSVC required for building this?

-Ian

On Mon, Jul 1, 2019 at 1:26 PM Simon Richter <Simon.Richter@xxxxxxxxxx>
wrote:

> Hi,
>
> this is a rework of Tom's rework of my MSVC branch, compile-tested on
> Linux, MSYS2 and MSVC. The full branch is on Launchpad, as
>
>     https://git.launchpad.net/~sjr/kicad/msvc-new .
>
> Before we can merge this, this needs more extensive testing, and a few
> reviews. If you want to try binaries from MSVC, get them from the build
> artifacts of the appropriate configuration below
>
>     https://jenkins.simonrichter.eu/job/windows-kicad-msvc-tom/
>
> I've snuck in the "Turn off compiler extensions" patch again, that one is
> optional (and breaks MSYS2 without a particular workaround, so we need to
> decide if we want it). The other patches are fairly straightforward.
>
> Including <config.h> probably makes sense everywhere, not just in the files
> where we need strncasecmp.
>
>    Simon
>
> Simon Richter (6):
>   Set _USE_MATH_DEFINES on Windows
>   Turn off compiler extensions
>   Remove own copy of FindOpenSSL.cmake
>   Work around missing min/max in Windows headers
>   Pull in macro definition for strncasecmp on MSVC
>   Define compiler flags for MSVC
>
> Tomasz Wlostowski (3):
>   pcbnew: can't return a copy of ptr_vector if items are polymorphic and
>     have no clone() methods. Work it around.
>   Export LIB_TREE_ITEM
>   MSVC support for libcontext
>
>  CMakeLists.txt                   |  49 ++++++
>  CMakeModules/FindOpenSSL.cmake   | 342
> ---------------------------------------
>  common/gal/cairo/cairo_print.cpp |   6 +
>  common/system/libcontext.cpp     |  66 ++++++++
>  eeschema/sim/ngspice.cpp         |   1 +
>  include/lib_tree_item.h          |   4 +-
>  include/system/libcontext.h      |  16 +-
>  include/tool/coroutine.h         |   8 +-
>  pcbnew/pcb_edit_frame.h          |   3 +-
>  pcbnew/pcbnew_config.cpp         |  12 +-
>  10 files changed, 153 insertions(+), 354 deletions(-)
>  delete mode 100644 CMakeModules/FindOpenSSL.cmake
>
> --
> 2.11.0
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Follow ups

References