kicad-developers team mailing list archive

[Jeff Young <jeff@xxxxxxxxx>]

Hi Seth,

Let’s say that you change the datasheet of a component that exists in two sheets.  The undo information needs to go in each sheet.  Now you go to the other sheet and perform another action.  The datasheet change is now the second item on the stack in that sheet.  Now you go back to the original sheet and undo (the datasheet change is at the top here).  What do we do in the other sheet?

An alternative is to view the whole hierarchy as a single document and just maintain a single undo stack.  I still like that; JP still doesn’t.  The current proposal is a compromise.

Cheers,
Jeff.

> On 2 Jul 2019, at 14:20, Seth Hillbrand <seth@xxxxxxxxxxxxx> wrote:
> 
> On 2019-07-02 02:51, Jeff Young wrote:
>> I think I’ve figured out a neat (and easy) way to solve multi-sheet undo:
>> 1) move the undo stacks to the SCH_EDIT_FRAME
>> 2) stack sheet navigations as undoable operations
>> This way the conceptual sheet-specific stacks can’t get out of
>> alignment as you have to go through the sheet navigation undo’s to get
>> to them.  And you can’t accidentally undo things that you’re not
>> focusing on (with the exception of hierarchy-wide ops like Replace
>> All, but that should be expected).
>> Thoughts?
> 
> Maybe...  My first impression though is that I think that could be a frustrating experience.
> 
> Remind me why we can't put the undo stack in SCH_SCREEN next to the drawlist?
> 
> -Seth