← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH 1/1] Fix build order for generated headers and sources

 

On 2019-07-02 12:21, Simon Richter wrote:
Hi,

On Tue, Jul 02, 2019 at 11:42:30AM -0400, Seth Hillbrand wrote:

Instead of banging on this dependency, I could push option #2 from
my previous e-mail.  This was creating a separate target to rebuild
the generated files and checking them into the source tree.  Then we
don't try to rebuild them as part of our standard build.  This is
analogous to how we handle the bitmaps.

If we could avoid that, that would be nice, because it'd be another special
thing for people to know. We mainly do this for the bitmaps to avoid a
dependency on inkscape and pngcrush, and there seems to be a
nondeterministic element in there as well.

The reason we have our own lexer is to avoid the external tool dependency and still allow people to just change the word list. Otherwise, I'd just
convert all of this to GNU flex.

The last patch seems to have built correctly for me, so there is a good
chance that this works now. :)

   Simon

Oh, I missed that there was a patch attached to the last e-mail. Is there any chance you could output that with git format-patch? I can't apply it as attached, I get 'Patch format detection failed'.

-Seth


Follow ups

References