← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH 1/1] Fix build order for generated headers and sources

 

Looks good on Debian also. Tried to break it with varying parallelisms and file mods. No issues.

Nice work, Simon!

On 2019-07-02 15:35, Wayne Stambaugh wrote:
I gave this a quick test on msys2 builds and it seems to work fine for me.

On 7/2/2019 11:31 AM, Simon Richter wrote:
Hi,

On Mon, Jul 01, 2019 at 12:33:43PM -0400, Seth Hillbrand wrote:

[ 38%] Building CXX object eeschema/CMakeFiles/eeschema_kiface_objects.dir/widgets/symbol_tree_pane.cpp.o
/home/seth/code/kicad/kicad_bare/eeschema/dialogs/panel_sym_lib_table.cpp:29:10:
fatal error: lib_table_lexer.h: No such file or directory
 #include <lib_table_lexer.h>
          ^~~~~~~~~~~~~~~~~~~
compilation terminated.

Okay, that patch was some progress at least, as it reduced the problem from
"two paths build the same file" to "missing dependency".

With some help from #cmake on IRC, I think the problem is in the way the
OBJECT library is used -- we copy the bits we need (include path and
objects) by hand rather than using target_link_libraries(), because the
latter doesn't work with CMake < 3.9.

When I also add an explicit dependency, it seems to work, but that was just
the initial test now.

   Simon


_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Follow ups

References