← Back to team overview

kicad-developers team mailing list archive

BUILD NOTICE: one-time change required for new lexer generation architecture

 

It’s a search path issue.  The lexer.h files are now generated in the local directory, but they need to be deleted out of include/ or the local ones won’t be found.

Cheers,
Jeff.


> On 3 Jul 2019, at 21:11, Jeff Young <jeff@xxxxxxxxx> wrote:
> 
> What are the new instructions for generating the lexer files?  (Or if it’s supposed to be automatic, is there something I need to do to update my tree to make it so?)
> 
> Thanks,
> Jeff.
> 
> 
>> On 3 Jul 2019, at 10:08, Simon Richter <Simon.Richter@xxxxxxxxxx> wrote:
>> 
>> 
>> This changes make_lexer() so that it no longer generates a custom target
>> but instead attaches the generated files to an existing one (so the first
>> argument now is the name of an existing library or executable, and it needs
>> to come after the add_library/add_executable call).
>> 
>> The generated source is no longer listed in the project sources, as it is
>> added by the function. The files are generated in the build tree rather
>> than the source tree, and the directory is added to the include path for
>> the respective project as well as exported to projects linking against it.
>> 
>> Generated files in subdirectories are somewhat supported, but need to be
>> referenced with the same name as they were generated (i.e. including the
>> subdirectory name).
>> ---
>> CMakeModules/Functions.cmake              | 27 ++++--------
>> CMakeModules/TokenList2DsnLexer.cmake     |  2 +-
>> common/CMakeLists.txt                     | 73 +++++++++----------------------
>> common/page_layout/page_layout_reader.cpp |  2 +-
>> common/page_layout/ws_data_model_io.cpp   |  2 +-
>> eeschema/CMakeLists.txt                   | 52 ++++++++++------------
>> eeschema/dialogs/dialog_bom.cpp           |  2 +-
>> new/CMakeLists.txt                        | 26 +++++------
>> pcb_calculator/CMakeLists.txt             | 14 ++----
>> pcbnew/CMakeLists.txt                     | 33 ++++++--------
>> pcbnew/specctra_import_export/specctra.h  |  2 +-
>> qa/eeschema/CMakeLists.txt                |  5 +--
>> 12 files changed, 89 insertions(+), 151 deletions(-)
>> 
>> <v2-0001-Fix-build-order-for-generated-headers-and-sources.patch>_______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp



Follow ups

References