← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH v2 0/8] MSVC Build

 

I have to apply the patches, build, and test.  I should be able to get
to it over the weekend.  My only comment is on patch #1.  I would have
preferred that we implemented the missing boost pointer container object
clone methods rather the work around.  As a temporary fix I could live
with this but it just feels wrong to me.  Everything else seems pretty
straight forward.  I definitely want to get some testing due to the
changes to make sure nothing is broken before we cherry pick this to the
5.1 branch.

Wayne

On 7/12/2019 1:10 PM, Seth Hillbrand wrote:
> Agreed.  Wayne are you comfortable with this?
> 
> -S
> 
> On 2019-07-11 15:00, Nick Østergaard wrote:
>> It looks like people are happy with the patches, can we get them
>> merged so they don't get lost and we don't need to rebase them locally
>> all the time?
>>
>> On Fri, 5 Jul 2019 at 19:01, Simon Richter <Simon.Richter@xxxxxxxxxx>
>> wrote:
>>>
>>> Hi,
>>>
>>> On Fri, Jul 05, 2019 at 06:24:45PM +0200, Tomasz Wlostowski wrote:
>>>
>>> > > I can't test the Windows functionality but this doesn't appear to
>>> break
>>> > > anything on Linux.
>>>
>>> > I'm ok with Simon's patches. Can give them a try on MSVC, but I'm
>>> pretty
>>> > confident they will work already.
>>>
>>> These are tested on Linux (with "git rebase -x make", so individual
>>> commits
>>> compile on their own) and Windows with MSYS2 and MSVC through Jenkins. I
>>> can't test MacOS.
>>>
>>> > @Simon: Now that we'll be supporting MSVC, should we put a 'MSVC
>>> > precompiled library kit' somewhere on Kicad webpage to spare people
>>> the
>>> > hassle of finding the right version on Jenkins?
>>>
>>> Yes, can do. I'm going to investigate vcpkg as well, since it has cmake
>>> integration, so it reduces to "tell vcpkg that we need these
>>> packages, and
>>> tell cmake to talk to vcpkg". My initial experiments were promising, it
>>> seems to be missing oce and ngspice, and I'm unsure about the status of
>>> wxpython, but everything else seems to be there.
>>>
>>>    Simon
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


Follow ups

References