kicad-developers team mailing list archive
Mailing list archive
Re: Message Dialogs
Wayne Stambaugh <stambaughw@xxxxxxxxx>
Mon, 22 Jul 2019 08:15:20 -0400
addr=stambaughw@xxxxxxxxx; prefer-encrypt=mutual; keydata= mQGiBEM0hxQRBAC2fNh3YOVLu1d5GZ0SbrTNldGiGnCJPLqzEnqFX9v6jmf33TMt6EmSLkl6 Wtfkoj0nVwKxcYmJkA8DX0QAokBkwNIzhSsBzQvthBLIk/5LnPVVKrEXOcL4mUyH1doKlkaE slgJozNa6Av+oavcvD02o1zJOloBbaHlNlyRt7fKswCgtIFlVjWggVH/15KfWk+Qo5JVPbME AIUBAQyL2OAx0n60AWec2WHnO9buHuG0ibtICgUMkE+2MRmYyKwYRdyVwGoIUemFuOyHp0AJ InX4T+vy2E7vkwODqjtMLfIoRkokW74Fi4nrvjlhOAw/vdq/twLbAmR9MOfPTpR4y7kQy1O2 /n+RkkRvh26vTzfbQmrH7cBJhk6aA/9Uwvu3E4zNJgHVZeS0HyWtmR1eOPPRbnkPgJTToX5O KMKzTJI/FX6kT7cFoCamitHrW3BJP4Dx+cMMsa47EGxqVTdbVJ4LjogsXTXxb+0Fn1u4zBdx x3Cer6O7+hqWy7zvpzeC6nSREjqDKa5CgHtv/GLm5uFPOmsjAsnHj2tlBrQmV2F5bmUgU3Rh bWJhdWdoIDxzdGFtYmF1Z2h3QGdtYWlsLmNvbT6IeAQTEQIAOBYhBOffs6CbblRzBkv33BtR cWlZ+CReBQJbFBS2AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEBtRcWlZ+CReMI8A nRbrLkzp7+c2f0vX7sfg4ICX8LAKAJ9uClo4uJajmZa5zZrL2nKdZlUwIrkCDQRDNIcxEAgA gCru+3/aOC6RCjpvYC72wY+d5SmHphC6yeiV2/mOumyt5MLo/Ps2GznZr11JspqFk5K/Zpvp MMLqqjDZ39+50a2iKRQFJ6NlK+hJWMmj6eJygQrCwYo3Gjc6CqfrqUv+8VSnf/i5sIZmtOVA 4ZjML18MuBvMSsNdVLFJd5HNnYb1iOECpvqdPVh/21LLCEw7MUUGGnHBhCrmk2aJe5hFmcSN g4ldBcXrgMQBwf7aMVoobXBMFDb/IENByXn0llB7Gr2IFMRmNS9/p8s/II1Yl2bTqyX4FSz8 cfn7C9KEz7faZ7wzAcpwHFC/zs3JoAjJ0IEKdNUpIwAlKMzT3CzctwADBQf/cxpG28MKyrqk nNmq/8LQLy+x6FSYXBLjxQz9BiBNYeesDZQ6J5UbL1mjpJzMa5tLZypPYo4bbGyR22hrbyDF K7m6AcVaMIJKl98g4ukMutFfAJyRDaREH5Zl/X1P4u1Z/yaAIy9mKaNbaK1/5djNJ5wCTFen TUgAp9xdc30kGkFDdLJFp5uxDY4P0vaZiZdjUCvDM3Zjv5IzpNOfxVqTUBQNUP/BnnKhkk0p DTD6s3X8S+D0rOtEBQ8K0cwERI/E8EFa8nj0TNw4e2MYGR8wg+SxqJ7z5f0zPY0bO6G9DDFB wYCqzzPWGqdAh9vA5971TAbPERtdFybhkurozp2SfYhJBBgRAgAJBQJDNIcxAhsMAAoJEBtR cWlZ+CResHUAniULLCWiT26ieRTl7N2vS6vBo/DuAJ4m7Ss/gyiW6ybTn1ctDXAUgm2QVQ==
KiCad Developers <kicad-developers@xxxxxxxxxxxxxxxxxxx>
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0
On 7/22/19 2:48 AM, Ian McInerney wrote:
> I never have understood what the Gnome folks do either (hence why I use
> Mate and the Gnome 2 look I guess :) ). It also looks like the lack of
> the image in the dialog is an intentional choice by Gnome now.
> I will have to figure out a way around the bold text issue in the
> wxRichMessageDialog though, and unfortuently the only bandage that we
> can apply to the KiCad code will be to resize the wxRichMessageDialogs
> to fit the text. The better solution must be implemented inside
> wxWidgets itself. I haven't even thought of a way to fix the bold text
> in the other windows yet (which is caused by yet another design choice
> by the Gnome folks...).
Have you tested this on wxWidgets 3.1? The bold text issue may have
already been resolved.
> On Mon, Jul 22, 2019 at 1:12 AM Wayne Stambaugh <stambaughw@xxxxxxxxx
> <mailto:stambaughw@xxxxxxxxx>> wrote:
> While I like the appearance of your dialogs better, they do not look
> native on GTK3 like the last two images. While I may not agree with the
> Gnome folks design choices all of the time, I would rather avoid making
> KiCad look like it uses it's own widgets toolkits. Using the stock
> platform dialogs over custom dialogs is preferable whenever possible.
> On 7/20/19 5:19 AM, Ian McInerney wrote:
> > There has been a brief discussion in this bug
> > (https://bugs.launchpad.net/kicad/+bug/1836498) about removing the
> > text from the save dialogs, and instead having all the text as normal
> > font. Part of this is because wxWidgets has an annoying bug with
> > bold text on GTK, and the other part is it does seem to look better
> > without the bold text (see the proposed save dialog attached for
> how it
> > looks on GTK).
> > I am also thinking that unifying some of the dialogs to use
> > wxRichMessageDialog instead of wxMessageDialog would be useful.
> For the
> > save changes dialog, the Mac builds already always use
> > wxRichMessageDialog for every dialog, while Linux and Windows use both
> > wxRichMessageDialog and wxMessageDialog depending on the application.
> > The rich message version appears cleaner on GTK (see attached)
> than the
> > normal message version (which also isn't showing the icon on Linux it
> > seems).
> > I also think it might be good to discuss doing this to the other
> > to try to unify their look across the board. An example for making
> > change to the revert dialog is attached. This converts it from the
> > normal message dialog to a rich message dialog. (There are
> probably many
> > others we could look at as well, but these are just the two I played
> > with currently).
> > I have attached a sample patch that changes these dialogs so
> people can
> > try it (do not commit this, it is a test only and can be made much
> > cleaner if we actually want to use it). I would like to get feedback
> > from people, and also find out how this looks on Windows (Jeff already
> > says it looks better on Mac).
> > Thoughts?
> > -Ian
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help : https://help.launchpad.net/ListHelp
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp