← Back to team overview

kicad-developers team mailing list archive

Re: Message Dialogs

 

On 7/22/19 2:48 AM, Ian McInerney wrote:
> Wayne,
> 
> I never have understood what the Gnome folks do either (hence why I use
> Mate and the Gnome 2 look I guess :) ). It also looks like the lack of
> the image in the dialog is an intentional choice by Gnome now.
> 
> I will have to figure out a way around the bold text issue in the
> wxRichMessageDialog though, and unfortuently the only bandage that we
> can apply to the KiCad code will be to resize the wxRichMessageDialogs
> to fit the text. The better solution must be implemented inside
> wxWidgets itself. I haven't even thought of a way to fix the bold text
> in the other windows yet (which is caused by yet another design choice
> by the Gnome folks...).

Have you tested this on wxWidgets 3.1?  The bold text issue may have
already been resolved.

> 
> -Ian
> 
> On Mon, Jul 22, 2019 at 1:12 AM Wayne Stambaugh <stambaughw@xxxxxxxxx
> <mailto:stambaughw@xxxxxxxxx>> wrote:
> 
>     Ian,
> 
>     While I like the appearance of your dialogs better, they do not look
>     native on GTK3 like the last two images.  While I may not agree with the
>     Gnome folks design choices all of the time, I would rather avoid making
>     KiCad look like it uses it's own widgets toolkits.  Using the stock
>     platform dialogs over custom dialogs is preferable whenever possible.
> 
>     Cheers,
> 
>     Wayne
> 
>     On 7/20/19 5:19 AM, Ian McInerney wrote:
>     > There has been a brief discussion in this bug
>     > (https://bugs.launchpad.net/kicad/+bug/1836498) about removing the
>     bold
>     > text from the save dialogs, and instead having all the text as normal
>     > font. Part of this is because wxWidgets has an annoying bug with
>     sizing
>     > bold text on GTK, and the other part is it does seem to look better
>     > without the bold text (see the proposed save dialog attached for
>     how it
>     > looks on GTK). 
>     >
>     > I am also thinking that unifying some of the dialogs to use
>     > wxRichMessageDialog instead of wxMessageDialog would be useful.
>     For the
>     > save changes dialog, the Mac builds already always use
>     > wxRichMessageDialog for every dialog, while Linux and Windows use both
>     > wxRichMessageDialog and wxMessageDialog depending on the application.
>     > The rich message version appears cleaner on GTK (see attached)
>     than the
>     > normal message version (which also isn't showing the icon on Linux it
>     > seems).
>     >
>     > I also think it might be good to discuss doing this to the other
>     dialogs
>     > to try to unify their look across the board. An example for making
>     this
>     > change to the revert dialog is attached. This converts it from the
>     > normal message dialog to a rich message dialog. (There are
>     probably many
>     > others we could look at as well, but these are just the two I played
>     > with currently).
>     >
>     > I have attached a sample patch that changes these dialogs so
>     people can
>     > try it (do not commit this, it is a test only and can be made much
>     > cleaner if we actually want to use it). I would like to get feedback
>     > from people, and also find out how this looks on Windows (Jeff already
>     > says it looks better on Mac).
>     >
>     > Thoughts?
>     >
>     > -Ian
>     >
>     > _______________________________________________
>     > Mailing list: https://launchpad.net/~kicad-developers
>     > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     > Unsubscribe : https://launchpad.net/~kicad-developers
>     > More help   : https://help.launchpad.net/ListHelp
>     >
> 
>     _______________________________________________
>     Mailing list: https://launchpad.net/~kicad-developers
>     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     Unsubscribe : https://launchpad.net/~kicad-developers
>     More help   : https://help.launchpad.net/ListHelp
> 


Follow ups

References