kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Hi Thomas,

I tested your patches and they seem to work as advertised.  I don't have
a copy of Eagle to confirm that the conversions are correct.  I can only
test to see if the import is as expected with your patches.  I went
ahead a merged them into the master branch.  We can always revert them
if there are issues.  Thank you for your contribution to KiCad.

Cheers,

Wayne

On 7/17/19 10:33 AM, Thomas Pointhuber wrote:
> I would like to send a ping for my two eagle importer fixes.
> 
> The fix for handling filled circles should be included into 5.1.3, the
> other one only affects nightly.
> 
> Both bugs can be reproduced with: https://github.com/SHA2017-badge/PCB
> 
> Bugs fixed for this specific board:
> 
> * silkscreen for button A and B are not filled (width=0)
> * zone is not hatched
> 
> when you look a bit more on the eagle board, you will certainly find
> some more import bugs which are not fixed at the moment :). (DRC,
> silk-polygon,...)
> 
> Regards, Thomas
> 
> Am 12.07.19 um 21:26 schrieb Thomas Pointhuber:
>> Hi,
>>
>> I noticed that my fix for circles in the eagle import was only partial.
>> Namely there is something like a "plain section", where I missed to
>> handle the case of width=0. Now we fill those circles as well :).
>>
>> Regard, Thomas
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>