kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #41729
Re: [PATCH] Board statistics dialog
-
To:
kicad-developers@xxxxxxxxxxxxxxxxxxx
-
From:
Wayne Stambaugh <stambaughw@xxxxxxxxx>
-
Date:
Sun, 28 Jul 2019 10:03:43 -0400
-
Autocrypt:
addr=stambaughw@xxxxxxxxx; keydata= mQGiBEM0hxQRBAC2fNh3YOVLu1d5GZ0SbrTNldGiGnCJPLqzEnqFX9v6jmf33TMt6EmSLkl6 Wtfkoj0nVwKxcYmJkA8DX0QAokBkwNIzhSsBzQvthBLIk/5LnPVVKrEXOcL4mUyH1doKlkaE slgJozNa6Av+oavcvD02o1zJOloBbaHlNlyRt7fKswCgtIFlVjWggVH/15KfWk+Qo5JVPbME AIUBAQyL2OAx0n60AWec2WHnO9buHuG0ibtICgUMkE+2MRmYyKwYRdyVwGoIUemFuOyHp0AJ InX4T+vy2E7vkwODqjtMLfIoRkokW74Fi4nrvjlhOAw/vdq/twLbAmR9MOfPTpR4y7kQy1O2 /n+RkkRvh26vTzfbQmrH7cBJhk6aA/9Uwvu3E4zNJgHVZeS0HyWtmR1eOPPRbnkPgJTToX5O KMKzTJI/FX6kT7cFoCamitHrW3BJP4Dx+cMMsa47EGxqVTdbVJ4LjogsXTXxb+0Fn1u4zBdx x3Cer6O7+hqWy7zvpzeC6nSREjqDKa5CgHtv/GLm5uFPOmsjAsnHj2tlBrQmV2F5bmUgU3Rh bWJhdWdoIDxzdGFtYmF1Z2h3QGdtYWlsLmNvbT6IeAQTEQIAOBYhBOffs6CbblRzBkv33BtR cWlZ+CReBQJbFBS2AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEBtRcWlZ+CReMI8A nRbrLkzp7+c2f0vX7sfg4ICX8LAKAJ9uClo4uJajmZa5zZrL2nKdZlUwIrkCDQRDNIcxEAgA gCru+3/aOC6RCjpvYC72wY+d5SmHphC6yeiV2/mOumyt5MLo/Ps2GznZr11JspqFk5K/Zpvp MMLqqjDZ39+50a2iKRQFJ6NlK+hJWMmj6eJygQrCwYo3Gjc6CqfrqUv+8VSnf/i5sIZmtOVA 4ZjML18MuBvMSsNdVLFJd5HNnYb1iOECpvqdPVh/21LLCEw7MUUGGnHBhCrmk2aJe5hFmcSN g4ldBcXrgMQBwf7aMVoobXBMFDb/IENByXn0llB7Gr2IFMRmNS9/p8s/II1Yl2bTqyX4FSz8 cfn7C9KEz7faZ7wzAcpwHFC/zs3JoAjJ0IEKdNUpIwAlKMzT3CzctwADBQf/cxpG28MKyrqk nNmq/8LQLy+x6FSYXBLjxQz9BiBNYeesDZQ6J5UbL1mjpJzMa5tLZypPYo4bbGyR22hrbyDF K7m6AcVaMIJKl98g4ukMutFfAJyRDaREH5Zl/X1P4u1Z/yaAIy9mKaNbaK1/5djNJ5wCTFen TUgAp9xdc30kGkFDdLJFp5uxDY4P0vaZiZdjUCvDM3Zjv5IzpNOfxVqTUBQNUP/BnnKhkk0p DTD6s3X8S+D0rOtEBQ8K0cwERI/E8EFa8nj0TNw4e2MYGR8wg+SxqJ7z5f0zPY0bO6G9DDFB wYCqzzPWGqdAh9vA5971TAbPERtdFybhkurozp2SfYhJBBgRAgAJBQJDNIcxAhsMAAoJEBtR cWlZ+CResHUAniULLCWiT26ieRTl7N2vS6vBo/DuAJ4m7Ss/gyiW6ybTn1ctDXAUgm2QVQ==
-
In-reply-to:
<CACUysjve0Fzdq8d5n70xM2CY_c0S0EFJf6owWgVSBF3epA_O0w@mail.gmail.com>
-
Openpgp:
preference=signencrypt
-
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0
Diego,
Please file a bug report for this and include the board file that causes
this so it's easier for us to figure out what is going on.
Thanks,
Wayne
On 7/27/19 5:06 AM, Diego Herranz wrote:
> I've been testing this dialog and I think it is a nice addition. Thanks!
>
> There seems to be something wrong with the area calculation, though. See
> image below:
> area.png
>
> Thanks,
> Diego
>
> On Tue, 23 Jul 2019 at 11:18, Ian McInerney <Ian.S.McInerney@xxxxxxxx
> <mailto:Ian.S.McInerney@xxxxxxxx>> wrote:
>
> Alexander,
>
> Instead of declaring the 2 static variables separately, I would
> suggest creating a struct for the settings then store that as the
> static variable. For an example of this see the
> dialog_create_array.cpp file. This way if any new options must be
> added in the future, they can just be added to the struct very easily.
>
> -Ian
>
> On Mon, Jul 22, 2019 at 9:39 PM Alexander Shuklin <jasuramme@xxxxxxx
> <mailto:jasuramme@xxxxxxx>> wrote:
>
> Damn ><,
> don't use last patch, please.
> It doesn't count total vias amount. Use this one.
>
>
> Понедельник, 22 июля 2019, 22:14 +03:00 от Alexander Shuklin
> <jasuramme@xxxxxxx <mailto:jasuramme@xxxxxxx>>:
>
> Hi,
> thanks for sharing experience, as I never used that
> translations or wxWidgets before. And I have no idea where
> else could I get that information. ))
> So, there's the patch with vias information and some tiny
> improvements.
>
>
> Понедельник, 22 июля 2019, 13:34 +03:00 от Ian McInerney
> <ian.s.mcinerney@xxxxxxxx
> <mailto:ian.s.mcinerney@xxxxxxxx>>:
>
>
>
> On Mon, Jul 22, 2019 at 11:03 AM Dino Ghilardi
> <dino.ghilardi@xxxxxxxx
> <http://e.mail.ru/compose/?mailto=mailto%3adino.ghilardi@xxxxxxxx>>
> wrote:
>
> Hi Alexander,
>
> One possible solution for the translation could be
> put the ":" in a
> different column of the table and right-align the
> field description text
> (so all the colons will be aligned). A rapid google
> search shown that in
> French and Vietnamese there should be a space before
> the colon, while in
> the rest of the world there is not, so having the
> translation for the
> ":" word seems to make sense. Also another question
> arises: Is there
> some language in which the colon should be another
> character before the
> word? (I'm thinking about spanish where the question
> mark upside-down
> appears before a question...)? ...conclusion:
> keeping "Height:" and
> "Height" as two different words seem to be the
> solution that gives
> maximum flexibility to translators.
>
>
> This actually doesn't give them as much flexibility.
> When translations are done, they need to examine the
> entire string that needs translating, so the ":"
> character should be included in the string. Separating
> out the two portions is the equivalent of saying that
> every lanugage will follow the same compositional rules.
>
>
> Another possible solution (probably better then the
> one above since it
> just removes the problem) is to remove the ":" and
> have the cell borders
> in a different color, just like the tables in the
> "board setup" dialog
> (so that you can also take a look at that code to
> solve also the color
> problem seeing how it was solved there). The
> advantage of this approach
> is also having a more consistent "look" through all
> the dialogs.
>
>
>
> P.S. (a little bit off-topic):
> If you move the statistic window and check/uncheck
> one of the checkboxes
> ("subctract holes...." or "Exclude components...")
> the window "jumps" to
> the center of the screen (its default position on
> open): do you have
> also this behaviour or it is just on my debian-linux
> with gtk3?
>
>
> Cheers,
> Dino.
>
> On 22/07/19 10:13, Alexander Shuklin wrote:
> > Hi!
> > I'll have a look to add vias count to dialog.
> > There's some questions:
> >
> > 1)I don't have too much experience with wxdialogs.
> There was commit on
> > master, which says:
> > >> remove settings for fg/bg color: the result is
> unpredictable: was
> > black texts on black background on my computer.
> > And now I have all tables with data just in white
> boxes. Is it how it
> > meant to be, or just some misbehavior on different
> systems? I use
> > archlinux x64 OS.
> > there's screenshot in attachment
> >
> > 2) Can we use something like _( "Height" ) + ":"
> for translation, not _(
> > "Height:" )? As far as I understand, now we will
> need to have 2
> > translations, first for "Height" and second for
> "Height:" but that's
> > basically same word.
> >
> > Воскресенье, 21 июля 2019, 23:42 +03:00 от
> Dino Ghilardi
> > <dino.ghilardi@xxxxxxxx
> <http://e.mail.ru/compose/?mailto=mailto%3adino.ghilardi@xxxxxxxx>>:
> >
> > Makes sense.
> > Instead of a generic "via count" a more
> complete table similar to the
> > one generated in the drill report file could
> be useful, but may be it
> > can became quite long if a lot of different
> drill sizes are used (ok,
> > scrollbars are made to handle that).
> > Also having "vias", "blind vias" and
> "microvias" count man make sense
> > (or at least having something like "microvias
> used: yes/no"), just to
> > have in board statistics the information about
> the need of an advanced
> > pcb manufacturing process.
> >
> >
> > Cheers,
> > Dino.
> >
> >
> > On 21/07/19 20:54, Mark Roszko wrote:
> > > > Since making every hole in the pcb costs
> time, manufacturers
> > > calculate the price of the PCB using also
> that number.
> > >
> > > A long time ago, holes cost alot. These
> days if your manufacturer is
> > > charging alot per hole, you should run far
> away. Usually
> > manufactuers
> > > include 20k-40k holes in the base price per
> panel before they start
> > > charging you tiny penny amounts for more in
> some increments of
> > > thousands. The CNC machines these days as
> blazing fast at making the
> > > holes required and they charge more for the
> drill bit being worn
> > down
> > > than the time.
> > >
> > > What does actually cost money is via type
> and size. Blind vias make
> > > layer stackups a pain in the butt and micro
> vias needing lasers.
> > > And also going below some via size can
> significantly add cost
> > even if
> > > not at microvia size because it requires
> different machines with
> > more
> > > precision and smaller drill bits.
> > >
> > >
> > > If anything I would say to break down the
> statistics based on via
> > type.
> > >
> > > On Sun, Jul 21, 2019 at 1:55 PM Dino Ghilardi
> > <dino.ghilardi@xxxxxxxx
> <http://e.mail.ru/compose/?mailto=mailto%3adino.ghilardi@xxxxxxxx>
> <mailto:dino.ghilardi@xxxxxxxx
> <http://e.mail.ru/compose/?mailto=mailto%3adino.ghilardi@xxxxxxxx>>
> > > <mailto:dino.ghilardi@xxxxxxxx
> <http://e.mail.ru/compose/?mailto=mailto%3adino.ghilardi@xxxxxxxx>>>
> wrote:
> > >
> > > I just tried the board statistics dialog
> and looks good, I like it.
> > >
> > > A thing I'd like to have to make it better
> is adding the number
> > of vias
> > > to the statistics: Since making every hole
> in the pcb costs time,
> > > manufacturers calculate the price of the
> PCB using also that number.
> > >
> > > Also the option to save or print a text
> with the statistics report
> > > would
> > > be nice.
> > >
> > >
> > > Cheers,
> > > Dino.
> > >
> >
> > _______________________________________________
> > Mailing list:
> https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> <http://e.mail.ru/compose/?mailto=mailto%3akicad%2ddevelopers@xxxxxxxxxxxxxxxxxxx>
> > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
> <http://e.mail.ru/compose/?mailto=mailto%3akicad%2ddevelopers@xxxxxxxxxxxxxxxxxxx>>
> > Unsubscribe :
> https://launchpad.net/~kicad-developers
> > More help : https://help.launchpad.net/ListHelp
> >
> >
> >
> > --
> > Alexander Shuklin
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> <http://e.mail.ru/compose/?mailto=mailto%3akicad%2ddevelopers@xxxxxxxxxxxxxxxxxxx>
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
>
>
> --
> Alexander Shuklin
>
>
>
> --
> Alexander Shuklin
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
Follow ups
References
