← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Crash Reporter

 

I rebased this for todays master and pushed it to:
https://github.com/nickoe/kicad-source-mirror/tree/tom-crash-reporter-may27_rebased20190729

Diff view of changes:
https://github.com/nickoe/kicad-source-mirror/compare/7b5b807...nickoe:tom-crash-reporter-may27_rebased20190729?expand=1

I don't think I let it follow the recent style in mater about the menu:
https://github.com/nickoe/kicad-source-mirror/compare/7b5b807...nickoe:tom-crash-reporter-may27_rebased20190729?expand=1#diff-512ddae11b132baba0403a7df0fc215bR376

I did see it build on archlinux and it did report to launchpad with
the menu entry to test the crash reporter.

I still need to test it on windows.

On Tue, 16 Jul 2019 at 13:01, Nick Østergaard <oe.nick@xxxxxxxxx> wrote:
>
> It looks like some of the errors are related to the lexer stuff. Can
> you try to rebase your branch to latest master?
>
> On Tue, 16 Jul 2019 at 13:00, Nick Østergaard <oe.nick@xxxxxxxxx> wrote:
> >
> > @Tomasz Wlostowski  I am trying to build against wx3.1, but I get
> > build errors, please review the build log:
> >
> > https://jenkins.simonrichter.eu/job/windows-kicad-msys2-patch/465/console
> >
> > On Tue, 16 Jul 2019 at 12:37, Nick Østergaard <oe.nick@xxxxxxxxx> wrote:
> > >
> > > Hmm, ok, I guess you mean the -may27 one.. it seem to have never commits.
> > >
> > > https://github.com/twlostow/kicad-dev/tree/tom-crash-reporter-may27
> > >
> > > On Tue, 16 Jul 2019 at 11:08, Tomasz Wlostowski
> > > <tomasz.wlostowski@xxxxxxx> wrote:
> > > >
> > > > On 15/07/2019 14:43, Nick Østergaard wrote:
> > > > > Remind me, is this feature still in a seperate branch to master, or
> > > > > how is it enabled?
> > > >
> > > > IIRC it's still tom-crash-reporter on my github and it's enabled in
> > > > CMake config (KICAD_CRASH_REPORTER=yes).
> > > >
> > > > T.
> > > >
> > > > >
> > > > > On Thu, 11 Jul 2019 at 21:08, Nick Østergaard <oe.nick@xxxxxxxxx> wrote:
> > > > >>
> > > > >> @Tomasz Wlostowski  I just found that it looks like someone has
> > > > >> uploaded a wxwidgets 3.1 pkgbuild for the mingw-packages for msys2, I
> > > > >> could try to build and and rebuild your branch for windows.
> > > > >>
> > > > >> https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-wxWidgets3.1/PKGBUILD
> > > > >>
> > > > >> On Tue, 9 Jul 2019 at 14:09, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
> > > > >>>
> > > > >>> Tom,
> > > > >>>
> > > > >>> On 7/9/19 2:41 AM, Tomasz Wlostowski wrote:
> > > > >>>> On 06/07/2019 21:10, Ian McInerney wrote:
> > > > >>>>> Tom,
> > > > >>>>>
> > > > >>>>> Not to pile on the questions, but does the linux stack trace support
> > > > >>>>> exist in the entire 3.0.x line, or how far back does it go? Currently,
> > > > >>>>> the minimum version searched by cmake is 3.0.0, and some major linux
> > > > >>>>> distros only have 3.0.2 (Debian Stable, EPEL6/7, and Ubuntu 16.04 to
> > > > >>>>> name a few).
> > > > >>>>
> > > > >>>> Hi,
> > > > >>>>
> > > > >>>> Under liunx stack trace works fine in 3.0.2. Under Windows it's not
> > > > >>>> implemented at all (unless using a crazy hack self-exception-raising
> > > > >>>> hack that works only under MSVC).
> > > > >>>>
> > > > >>>> I can work this around by having our own Windows stack walker - after
> > > > >>>> all the whole purpose  of the crash reporter was easy debug reports for
> > > > >>>> Windows users. Under Linux everyone knows how to use a debugger,
> > > > >>>> otherwise it's impossible to work ;-)
> > > > >>> I'm assuming that you mean that you are going to pull the
> > > > >>> wxDebugReporter code from the 3.1 branch of wxWidgets which can be
> > > > >>> removed once wxWidgets 3.2 becomes the default.  If it's any more than
> > > > >>> that, I would rather wait until 3.2 is available.
> > > > >>>
> > > > >>>>
> > > > >>>> Tom
> > > > >>>>
> > > > >>>
> > > > >>> _______________________________________________
> > > > >>> Mailing list: https://launchpad.net/~kicad-developers
> > > > >>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > > > >>> Unsubscribe : https://launchpad.net/~kicad-developers
> > > > >>> More help   : https://help.launchpad.net/ListHelp
> > > >


Follow ups

References