← Back to team overview

kicad-developers team mailing list archive

Re: [Patch] Log traces for tool dispatch

 

Hi Ian,

I merged your change.  Thanks for your contribution!

Cheers,
Jeff.


> On 31 Jul 2019, at 10:27, Ian McInerney <Ian.S.McInerney@xxxxxxxx> wrote:
> 
> Here is an updated patch. A recent commit made it not apply as cleanly as it should (and this also adds a trace for the search minus the shift).
> 
> -Ian
> 
> On Wed, Jul 31, 2019 at 6:20 PM Wayne Stambaugh <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>> wrote:
> I think the tracing might be useful given some of the tool dispatch
> issues we've been having lately.  Is there any reason not to merge this
> patch?
> 
> Cheers,
> 
> Wayne
> 
> On 7/27/19 12:33 PM, Ian McInerney wrote:
> > Whoops, ignore the patch in the last email since it appears a log
> > statement slipped out of an if null check. Here is an updated patch.
> > 
> > -Ian
> > 
> > On Sat, Jul 27, 2019 at 5:30 PM Ian McInerney <Ian.S.McInerney@xxxxxxxx <mailto:Ian.S.McInerney@xxxxxxxx>
> > <mailto:Ian.S.McInerney@xxxxxxxx <mailto:Ian.S.McInerney@xxxxxxxx>>> wrote:
> > 
> >     As I was working on the cvpcb actions, I needed to trace the tool
> >     dispatch routes through the stack, so I went ahead and added a new
> >     debug trace for monitoring the dispatch events. It is contained in
> >     the attached patch. I don't guarantee that I found every location
> >     they pass through, but I got the major ones.
> > 
> >     Hopefully this is useful enough to merge into master.
> > 
> >     -Ian
> > 
> > 
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> > Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> > More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
> > 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
> <0001-Add-log-trace-for-tool-handling.patch>_______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


References