← Back to team overview

kicad-developers team mailing list archive

Re: [Patch] Fix initialization order for COLOR4D statics

 

Thanks Ian.  This looks good.  Patch merged.

-Seth

On 2019-08-05 10:39, Ian McInerney wrote:
The updated patch using constexpr (which now only affects the color4d
files) is attached.

Simon, thanks for the suggestion to use constexpr. It ended up working
by just declaring the variables constexpr and also making one of the
constructors constexpr. Definitely much simpler.

-Ian

On Mon, Aug 5, 2019 at 2:10 PM Wayne Stambaugh <stambaughw@xxxxxxxxx>
wrote:

On 8/5/19 5:03 AM, Simon Richter wrote:
Hi,

On Mon, Aug 05, 2019 at 10:58:44AM +0200, Ian McInerney wrote:

I tracked it down to the fact that COLOR4D has some static colors
that were
being used to initialize some other static variables in pcbnew's
layer
widgets. I have moved all the static colors to an initialize on
first use
paradigm (so now we just call them like a function, e.g.
COLOR4D::UNSPECIFIED() ) to fix it.

Can that be solved by constexpr?

Simon


I would prefer the constexpr solution if it resolves the issue.  It
certainly would be a much simpler patch.

Wayne

_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp
_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


References