kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #41849
Re: [Patch] Another hotkey processing fix
-
To:
<kicad-developers@xxxxxxxxxxxxxxxxxxx>
-
From:
Maciej Suminski <maciej.suminski@xxxxxxx>
-
Date:
Fri, 9 Aug 2019 12:30:39 +0200
-
Arc-authentication-results:
i=1; mx.microsoft.com 1;spf=pass (sender ip is 188.184.36.46) smtp.rcpttodomain=lists.launchpad.net smtp.mailfrom=cern.ch;dmarc=bestguesspass action=none header.from=cern.ch;dkim=none (message not signed);arc=none
-
Arc-message-signature:
i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z1i0wv3WTtpRRXtln6fWAxbcs7W4u/PW2+CRy5SIxAM=; b=eLzvxSeCLRZvMvoNqNlR4R3GnJ6z4c+xSHRuFlVYiNz4cgVvK5GQLhmomQ7/MWYVm3/22YSmo0eqjEtbmu871mAX2Bzl2lXMWf52oMvf3kLdJK+KnpTjJTvJGuocF6wryaj6GJdVDqIQL1///LQHohp4pds1bJuFiUoyx0kMzsp+zH/6EATKgTtfddeq3uf2AxwJK2ZLzOoonuTQjimq/DXtainc/6V8SaRrplAFAban0w4IESSR4nHGCTndap210zqpYrULRE0SG4qQWTQMnY1nA7QLXZ7UFUpFK/JNx4I/FZqMkTlloOG73Rob8vBrCHq7ryWrfjPZpAMOHNLzlA==
-
Arc-seal:
i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I/DGXeeFGi40X9ra+9nw59/nI74ZsFu1QysFEN0t79r70AXFrnTs5t6QQcZQQMWcXFAd5Kbj/sIALAzkOM+Th8Y4oQ618RcGDuJs9xCWoyZ0Umv7YKBgpxlraqgTACJ2VWHpajMlp+Mr/JQKkc//4/sMuiGcn/ok0vZV1qtNANYddH46W3VRXgDP8SG8EtqbJsfbX7MK07T0KIT7qVr19JiUcaE8VEpUG7eis6cyf3fL8tGjiR3llL6sed9rwLNHcxByHWgJKlj7aqfY2Cz26Z+fWelyPxz0urrnJyEK+TwlsT6qOj3jKeTj7KhhgoJr4eIr0pBJ8nA3wGn/ow6FZg==
-
Authentication-results:
spf=pass (sender IP is 188.184.36.46) smtp.mailfrom=cern.ch; lists.launchpad.net; dkim=none (message not signed) header.d=none;lists.launchpad.net; dmarc=bestguesspass action=none header.from=cern.ch;
-
Autocrypt:
addr=maciej.suminski@xxxxxxx; keydata= mQENBFKfmAwBCAC9tak+4mDO1WiNnAwegusPBMEdl+sV35XeaU4PGSt33mPSlXB2klamg4ih QUykvuWqNEg2KyTvCSKNfnHTpzeeFegEsIwWFdhbIc4uUAD6CHl4+uGTXQiMh1+IJkgLmwuD RCEx9mSKbdzzTKz05w+fzzT3mNfko8NICWlcmhFgo2RXnQRTqFg7CNNBpx4kr4+AWIvb+Rha AVMLVJj1s05+STGyFucu6sZmTmOC53ZtkV8HchJeGuQL0LPkjvX0VKGE3gkvuP4iLBcgFtNC Kcu/L6FmWd24m2IhWaHXoWLBiVFw7gGzUdB7gSAiNO1+SoWX+99rbud7RvqV49vOgoqbABEB AAG0KU1hY2llaiBTdW1pbnNraSA8bWFjaWVqLnN1bWluc2tpQGNlcm4uY2g+iQE5BBMBAgAj BQJSn5gMAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQFHAa7WGlsnU/JQf5AYW0 oFH+jOykZvlRkRZMoqw1vZGOHeRPK92vbjeiau/hALYX1FBvZMx+JMmVHN7DkRIY7bVoiJ6N n4Byn//BSd9F9eXjAphYVuBg2Xe5wp3/l9/z2Iw8KeLpfKAtfIybgpycvTuUxFIxm9mtpPt+ AoNFKBDhfLcpZLJTW7AwwpnzP+GDdjszjnW6rMt8Aq55liR+y/TZfz/tTEDcUcSPLlJBTmda TmkO5aPxPmeCeDMOT3YEd+bK57V5b7RgtqTdIT6CW7tjQKBPJbIGa8PQ0tUfz0yCBEPWghnY w+B/2JeArrRXDui78cGgTDy1ocQNAm3havk2WO2qykxziY6OwbkBDQRSn5gMAQgAxw+MRllT IPNnCeOAbRgX1KRzo7+7WpSIbmhrBzLY0O1SyIa7U05E6+4jDHDfDpSLqc61an1+M69e6l9Z E3ve3hymtj5ucXZQnveQ5klD6z5FBC/04of/YyrS+h6iRSM0nOmu1JOIqM0S2OzwsKRsS86r jCtRE5OxoBDCIB4xNPitezs4uvLoVfO3mVYUhiPRZMtTCInEi+tlM+AmaPjRkPAfhd0wsOjk oxkuJWEnZ8U8oHpeL0uqANZgLlIiT5yJMWsyyqlK01hdFbuIydIFFiyXJw1HDTXWX+tMxJrX VEvQJZALof9RU/jntqGltnQXArUgPMSGGu1f+7AH/CuMyQARAQABiQEfBBgBAgAJBQJSn5gM AhsMAAoJEBRwGu1hpbJ1maAH/RZPbvXaNIOouHZlnlkq/WORHxjkKfve+AbE62Ed8yFIwlAj tyZGKeEG9hDJl6f9BxDv+9qunTfWfXQuHxNIpdXstkxQIx4m043Kx3h7VdEmg53ybeGNgpvz BYk5HdgCH3yP6UbGNiel6xZOywmvpru3pEKNg4mJhzxm9JCG+djrvbRh+BZNOkDBgaSiCAuJ q6Ffo9Qk/qfl6Uim9G7GKSS4930ZQ2GoVObe+jXixOhWXFSDhGKX5meABmELJ9XTcW3Pp6XC 0KXOE2p0EHQPmFvXdU6OePI72jTgRzPJXRXbPkL0/NUfbZfxS/xnAG8jmODc2ufbtrvE2jPu INX35u4=
-
In-reply-to:
<CACp=VfYfcqNQ4ObWcnByw9dOvtACpxXGX9hEG2vDF6RLAGWiow@mail.gmail.com>
-
Openpgp:
preference=signencrypt
-
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0
Hi Ian,
I have nothing against your patch, but is it a valid configuration where
one has multiple global actions bound to the same hot key?
Cheers,
Orson
On 8/9/19 1:16 AM, Ian McInerney wrote:
> In the current framework, if more than one global actions share the same
> hotkey (even if they are not all active in the current tool manager),
> the dispatcher will only choose the final action (in what seems to be
> alphabetical order) to run. I think that the correct behavior should
> instead be to loop through all global actions that have the hotkey until
> one handles it.
>
> The attached patch implements this change.
>
> -Ian
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
Follow ups
References